Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stuck notifications: DM stuck as unread #23991

Closed
Tracked by #24392
andybalaam opened this issue Dec 14, 2022 · 10 comments · Fixed by matrix-org/matrix-js-sdk#3139
Closed
Tracked by #24392

Stuck notifications: DM stuck as unread #23991

andybalaam opened this issue Dec 14, 2022 · 10 comments · Fixed by matrix-org/matrix-js-sdk#3139
Assignees
@germain-gg
Labels
A-DMs A-Notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@andybalaam
Copy link
Contributor

andybalaam commented Dec 14, 2022 •
edited
Loading

Steps to reproduce

  1. Refresh the Element Web page

Outcome

What did you expect?

My encrypted DM, which has no unread messages in it, is not marked as unread.

What happened instead?

This DM is marked as unread.

Operating system

Ubuntu 22.04

Browser information

Firefox 106.0.2

URL for webapp

https://develop.element.io

Application version

Element version: c4806b9-react-aeb9f4373fff-js-b2a10e6db323 Olm version: 3.2.12

Homeserver

matrix.org

Will you send logs?

Yes
@andybalaam
Copy link
Contributor Author

I added the room ID to the attached rageshake

@robintown robintown added O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Notifications A-DMs X-Needs-Investigation labels Dec 14, 2022
@andybalaam andybalaam mentioned this issue Jan 3, 2023
Closed
@ThoreKr
Copy link

ThoreKr commented Jan 3, 2023

To find similarities: Is the room encrypted?
Apparently the issue is currently limited to unencrypted rooms.

@andybalaam
Copy link
Contributor Author

andybalaam commented Jan 3, 2023 •
edited
Loading

This is happening to me in an encrypted DM (I updated the description to say that).

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Jan 10, 2023 •
edited
Loading

I have had this one encrypted DM pop-up as unread every time I refresh Element since December. Consistent every-time I refresh so I can easily grab more debugging info if you provide snippets to run. There hasn't been new activity in the room.

Rageshake logs: https://github.com/matrix-org/element-web-rageshakes/issues/19036

If the person in question from the video is onlooking, please don't send a DM to try to reset things. I'd rather reproduce until this is fixed.

chrome_2023-01-10_15-01-18.-.cut.mp4

Found other references to this type of problem:

@MadLittleMods MadLittleMods mentioned this issue Jan 10, 2023
Closed
@andybalaam
Copy link
Contributor Author

This is still happening to me. I am upgrading the frequency to O-Frequent.

@andybalaam andybalaam added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience and removed O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jan 11, 2023
@kittykat
Copy link
Contributor

I'm seeing this all the time with a specific DM

@germain-gg
Copy link
Contributor

Two PRs have landed yesterday to help with this issue. matrix-org/matrix-react-sdk#9763 and matrix-org/matrix-js-sdk#3031 .
Does this still happens in today's nightly if you do a "clear cache & reload"?

Let me know, and I'll investigate further if this does still occur.
@kittykat @andybalaam @MadLittleMods

@andybalaam
Copy link
Contributor Author

On develop.element.io I just did "clear cache & reload" and I still have a notification for the same DM (but no new message).

@kittykat
Copy link
Contributor

It was working ok yesterday, same DM is marked unread today again

@germain-gg
Copy link
Contributor

germain-gg commented Jan 13, 2023 •
edited
Loading

@andybalaam 's issue seem to be related to a synapse problem, we have filed matrix-org/synapse#14837

@kittykat 's bug was different and appears to be a client-side confusion of "cache receipts", I'm investigating this and should be able to come up with a solution

getEventReadUpTo and getReadReceiptForUserId seem to conflict, and return a reference to a different event. Making hasUserReadEvent determine that the wrong is unread and generated a "bold" notification

@Johennes Johennes mentioned this issue Feb 1, 2023
Open
@Johennes Johennes changed the title DM stuck as unread Stuck notifications: DM stuck as unread Feb 1, 2023
@germain-gg germain-gg mentioned this issue Feb 8, 2023
Merged
3 tasks
@germain-gg germain-gg self-assigned this Feb 8, 2023
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Feb 28, 2023
@su-ex
Merge tag 'v23.3.0' into sc
f94634a 
* Element-R: implement encryption of outgoing events ([\matrix-org#3122](matrix-org#3122)).
* Poll model - page /relations results ([\matrix-org#3073](matrix-org#3073)). Contributed by @kerryarchibald.
* Poll model - validate end events ([\matrix-org#3072](matrix-org#3072)). Contributed by @kerryarchibald.
* Handle optional last_known_event_id property in m.predecessor ([\matrix-org#3119](matrix-org#3119)). Contributed by @andybalaam.
* Add support for stable identifier for fixed MAC in SAS verification ([\matrix-org#3101](matrix-org#3101)).
* Provide eventId as well as roomId from Room.findPredecessor ([\matrix-org#3095](matrix-org#3095)). Contributed by @andybalaam.
* MSC3946 Dynamic room predecessors ([\matrix-org#3042](matrix-org#3042)). Contributed by @andybalaam.
* Poll model ([\matrix-org#3036](matrix-org#3036)). Contributed by @kerryarchibald.
* Remove video tracks on video mute without renegotiating ([\matrix-org#3091](matrix-org#3091)).
* Introduces a backwards-compatible API change. `MegolmEncrypter#prepareToEncrypt`'s return type has changed from `void` to `() => void`. ([\matrix-org#3035](matrix-org#3035)). Contributed by @clarkf.
* Stop the ICE disconnected timer on call terminate ([\matrix-org#3147](matrix-org#3147)).
* Clear notifications when we can infer read status from receipts ([\matrix-org#3139](matrix-org#3139)). Fixes element-hq/element-web#23991.
* Messages sent out of order after one message fails ([\matrix-org#3131](matrix-org#3131)). Fixes element-hq/element-web#22885 and element-hq/element-web#18942. Contributed by @justjanne.
* Element-R: fix a bug which prevented encryption working after a reload ([\matrix-org#3126](matrix-org#3126)).
* Element-R: Fix invite processing ([\matrix-org#3121](matrix-org#3121)).
* Don't throw with no `opponentDeviceInfo` ([\matrix-org#3107](matrix-org#3107)).
* Remove flaky megolm test ([\matrix-org#3098](matrix-org#3098)). Contributed by @clarkf.
* Fix "verifyLinks" functionality of getRoomUpgradeHistory ([\matrix-org#3089](matrix-org#3089)). Contributed by @andybalaam.
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Mar 15, 2023
@su-ex
Merge tag 'v23.4.0' into sc
0c0854b 
* Add easy way to determine if the decryption failure is due to "DecryptionError: The sender has disabled encrypting to unverified devices." ([\matrix-org#3167](matrix-org#3167)). Contributed by @florianduros.
* Polls: expose end event id on poll model ([\matrix-org#3160](matrix-org#3160)). Contributed by @kerryarchibald.
* Polls: count undecryptable poll relations ([\matrix-org#3163](matrix-org#3163)). Contributed by @kerryarchibald.
* Fix spec compliance issue around encrypted `m.relates_to` ([\matrix-org#3178](matrix-org#3178)).
* Fix reactions in threads sometimes causing stuck notifications ([\matrix-org#3146](matrix-org#3146)). Fixes element-hq/element-web#24000. Contributed by @justjanne.
* Better type guard parseTopicContent ([\matrix-org#3165](matrix-org#3165)). Fixes matrix-org/element-web-rageshakes#20177 and matrix-org/element-web-rageshakes#20178.
* Fix a bug where events in encrypted rooms would sometimes erroneously increment the total unread counter after being processed locally. ([\matrix-org#3130](matrix-org#3130)). Fixes element-hq/element-web#24448. Contributed by @Half-Shot.
* Stop the ICE disconnected timer on call terminate ([\matrix-org#3147](matrix-org#3147)).
* Clear notifications when we can infer read status from receipts ([\matrix-org#3139](matrix-org#3139)). Fixes element-hq/element-web#23991.
* Messages sent out of order after one message fails ([\matrix-org#3131](matrix-org#3131)). Fixes element-hq/element-web#22885 and element-hq/element-web#18942. Contributed by @justjanne.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-DMs A-Notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clear notifications when we can infer read status from receipts matrix-org/matrix-js-sdk
6 participants
@kittykat @andybalaam @MadLittleMods @germain-gg @ThoreKr @robintown