Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread replies appear out of order #23972

Closed
MadLittleMods opened this issue Dec 12, 2022 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2971
Closed

Thread replies appear out of order #23972

MadLittleMods opened this issue Dec 12, 2022 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2971
Assignees
@justjanne
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Dec 12, 2022 •
edited
Loading

Steps to reproduce

  1. First deal with Thread list panel is missing recent thread that I participated in #23971 (unsure how related)
  2. Refresh the page to try to get into a good state
  3. Open the room again and thread panel and notice the thread that was missing now shows up again
  4. Open the thread from the list and notice that the messages are out of order and a notification mention (stuck mention) for the message I've clearly already read and responded to (notice out of order timestamps).

Outcome

What did you expect?

Thread replies appear in order

What happened instead?

Thread replies appear out of order

Uncensored screenshot in the rageshake logs. Notice the message timestamps out of order at the end

Operating system

Windows 10

Browser information

Chrome Version 108.0.5359.99

URL for webapp

https://develop.element.io/

Application version

Element version: 60d05f0-react-d835721ae1dd-js-9c17eb6c14ec Olm version: 3.2.12

Homeserver

matrix.org

Will you send logs?

Yes, https://github.com/matrix-org/element-web-rageshakes/issues/18316
@t3chguy t3chguy added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely labels Dec 13, 2022
@justjanne justjanne mentioned this issue Dec 13, 2022
Merged
@justjanne justjanne self-assigned this Dec 13, 2022
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Jan 15, 2023
@su-ex
Merge tag 'v23.0.0' into sc
b9afe23 
* Process `m.room.encryption` events before emitting `RoomMember` events ([\matrix-org#2914](matrix-org#2914)). Fixes element-hq/element-web#23819.
* Don't expose `calls` on `GroupCall` ([\matrix-org#2941](matrix-org#2941)).
* Support MSC3391: Account data deletion ([\matrix-org#2967](matrix-org#2967)).
* Add a message ID on each to-device message ([\matrix-org#2938](matrix-org#2938)).
* Enable multiple users' power levels to be set at once ([\matrix-org#2892](matrix-org#2892)). Contributed by @GoodGuyMarco.
* Include pending events in thread summary and count again ([\matrix-org#2922](matrix-org#2922)). Fixes element-hq/element-web#23642.
* Make GroupCall work better with widgets ([\matrix-org#2935](matrix-org#2935)).
* Add method to get outgoing room key requests for a given event ([\matrix-org#2930](matrix-org#2930)).
* Fix messages loaded during initial fetch ending up out of order ([\matrix-org#2971](matrix-org#2971)). Fixes element-hq/element-web#23972.
* Fix #23919: Root message for new thread loaded from network ([\matrix-org#2965](matrix-org#2965)). Fixes element-hq/element-web#23919.
* Fix #23916: Prevent edits of the last message in a thread getting lost ([\matrix-org#2951](matrix-org#2951)). Fixes element-hq/element-web#23916 and element-hq/element-web#23942.
* Fix infinite loop when restoring cached read receipts ([\matrix-org#2963](matrix-org#2963)). Fixes element-hq/element-web#23951.
* Don't swallow errors coming from the shareSession call ([\matrix-org#2962](matrix-org#2962)). Fixes element-hq/element-web#23792.
* Make sure that MegolmEncryption.setupPromise always resolves  ([\matrix-org#2960](matrix-org#2960)).
* Do not calculate highlight notifs for threads unknown to the room ([\matrix-org#2957](matrix-org#2957)).
* Cache read receipts for unknown threads ([\matrix-org#2953](matrix-org#2953)).
* bugfix: sliding sync initial room timelines shouldn't notify ([\matrix-org#2933](matrix-org#2933)).
* Redo key sharing after own device verification ([\matrix-org#2921](matrix-org#2921)). Fixes element-hq/element-web#23333.
* Move updated threads to the end of the thread list ([\matrix-org#2923](matrix-org#2923)). Fixes element-hq/element-web#23876.
* Fix highlight notifications increasing when total notification is zero ([\matrix-org#2937](matrix-org#2937)). Fixes element-hq/element-web#23885.
* Fix synthesizeReceipt ([\matrix-org#2916](matrix-org#2916)). Fixes element-hq/element-web#23827 element-hq/element-web#23754 and element-hq/element-web#23847.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justjanne justjanne

Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix messages loaded during initial fetch ending up out of order matrix-org/matrix-js-sdk
3 participants
@MadLittleMods @t3chguy @justjanne