Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element sends call version 1 as a number, but it should be a string #22629

Closed
deepbluev7 opened this issue Jun 21, 2022 · 1 comment · Fixed by matrix-org/matrix-js-sdk#2471
Closed

Element sends call version 1 as a number, but it should be a string #22629

deepbluev7 opened this issue Jun 21, 2022 · 1 comment · Fixed by matrix-org/matrix-js-sdk#2471
Assignees
@SimonBrandner
Labels
A-VoIP O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Spec-Compliance An area where Element doesn't correctly implement the spec

Comments

@deepbluev7
Copy link

Steps to reproduce

  1. Start a call in Element
  2. Check the first event sent into the room

Outcome

What did you expect?

A "version": "1" call as required by the MSC: https://github.com/matrix-org/matrix-spec-proposals/pull/2746/files#diff-4d65532ebdb47ba1fd5ea93342395abfeaab0e911360c0bd8d8839be90afd7dfR21

What happened instead?

A "version": 1 call

Operating system

Linux

Browser information

No response

URL for webapp

riot.neko.dev

Application version

1.10.12

Homeserver

No response

Will you send logs?

No
@deepbluev7
Copy link
Author

Note, clients are allowed to interpret any number as 0, so you will be silently downgrading the call version, if you don't send it as a string.

@deepbluev7 deepbluev7 mentioned this issue Jun 21, 2022
Merged
@aaronraimist aaronraimist added A-VoIP Z-Spec-Compliance An area where Element doesn't correctly implement the spec labels Jun 23, 2022
@SimonBrandner SimonBrandner added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jun 25, 2022
@SimonBrandner SimonBrandner self-assigned this Jun 25, 2022
@SimonBrandner SimonBrandner mentioned this issue Jun 25, 2022
Merged
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Jul 7, 2022
@su-ex
Merge tag 'v19.0.0' into sc
2a6db46 
* Remove unused sessionStore ([\matrix-org#2455](matrix-org#2455)).
* Implement MSC3827: Filtering of `/publicRooms` by room type ([\matrix-org#2469](matrix-org#2469)).
* expose latestLocationEvent on beacon model ([\matrix-org#2467](matrix-org#2467)). Contributed by @kerryarchibald.
* Live location share - add start time leniency ([\matrix-org#2465](matrix-org#2465)). Contributed by @kerryarchibald.
* Log real errors and not just their messages, traces are useful ([\matrix-org#2464](matrix-org#2464)).
* Various changes to `src/crypto` files for correctness ([\matrix-org#2137](matrix-org#2137)). Contributed by @ShadowJonathan.
* Update MSC3786 implementation: Check the `state_key` ([\matrix-org#2429](matrix-org#2429)).
* Timeline needs to refresh when we see a MSC2716 marker event  ([\matrix-org#2299](matrix-org#2299)). Contributed by @MadLittleMods.
* Try to load keys from key backup when a message fails to decrypt ([\matrix-org#2373](matrix-org#2373)). Fixes element-hq/element-web#21026. Contributed by @duxovni.
* Send call version `1` as a string ([\matrix-org#2471](matrix-org#2471)). Fixes element-hq/element-web#22629.
* Fix issue with `getEventTimeline` returning undefined for thread roots in main timeline ([\matrix-org#2454](matrix-org#2454)). Fixes element-hq/element-web#22539.
* Add missing `type` property on `IAuthData` ([\matrix-org#2463](matrix-org#2463)).
* Clearly indicate that `lastReply` on a Thread can return falsy ([\matrix-org#2462](matrix-org#2462)).
* Fix issues with getEventTimeline and thread roots ([\matrix-org#2444](matrix-org#2444)). Fixes element-hq/element-web#21613.
* Live location sharing - monitor liveness of beacons yet to start ([\matrix-org#2437](matrix-org#2437)). Contributed by @kerryarchibald.
* Refactor Relations to not be per-EventTimelineSet ([\matrix-org#2412](matrix-org#2412)). Fixes matrix-org#2399 and element-hq/element-web#22298.
* Add tests for sendEvent threadId handling ([\matrix-org#2435](matrix-org#2435)). Fixes element-hq/element-web#22433.
* Make sure `encryptAndSendKeysToDevices` assumes devices are unique per-user. ([\matrix-org#2136](matrix-org#2136)). Fixes matrix-org#2135. Contributed by @ShadowJonathan.
* Don't bug the user while re-checking key backups after decryption failures ([\matrix-org#2430](matrix-org#2430)). Fixes element-hq/element-web#22416. Contributed by @duxovni.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonBrandner SimonBrandner

Labels
A-VoIP O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Spec-Compliance An area where Element doesn't correctly implement the spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Send call version 1 as a string matrix-org/matrix-js-sdk
3 participants
@aaronraimist @deepbluev7 @SimonBrandner