Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Threaded message appears in main timeline until a new event came in #21533

Closed
MadLittleMods opened this issue Mar 23, 2022 · 1 comment · Fixed by matrix-org/matrix-js-sdk#2256
Closed

Threaded message appears in main timeline until a new event came in #21533

MadLittleMods opened this issue Mar 23, 2022 · 1 comment · Fixed by matrix-org/matrix-js-sdk#2256
Assignees
@t3chguy
Labels
A-Threads A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs

Comments

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Mar 23, 2022 •
edited
Loading

Steps to reproduce

  1. Go to a room
  2. Send a threaded message
  3. Edit the threaded message
  4. Notice the duplicated thread message in the main timeline
  5. After a new event came in, the threaded message disappeared from the main timeline

In the image, both of the messages from me (MadLittleMods) are the same message with the same event_id when Viewing source on them.

Outcome

What did you expect?

No thread messages in the main timeline. Made me second guess whether the message was double sent.

What happened instead?

The threaded message appeared duplicated in the main timeline

Rageshake: https://github.com/matrix-org/element-web-rageshakes/issues/11633

Operating system

Windows 10

Browser information

Chrome Version 99.0.4844.74

URL for webapp

develop.element.io

Application version

Element version: e638abf-react-9ba1c97770d7-js-d0b964837f28 Olm version: 3.2.8

Homeserver

matrix.org

Will you send logs?

Yes

Rageshake logs: https://github.com/matrix-org/element-web-rageshakes/issues/11633

A similar reproduction: https://github.com/matrix-org/element-web-rageshakes/issues/11637
@MadLittleMods MadLittleMods added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Threads labels Mar 23, 2022
@MadLittleMods MadLittleMods changed the title Threaded message appears in main timeline until a new message came in Threaded message appears in main timeline until a new event came in Mar 23, 2022
@t3chguy t3chguy mentioned this issue Mar 23, 2022
Merged
@t3chguy t3chguy self-assigned this Mar 23, 2022
@t3chguy t3chguy mentioned this issue Mar 23, 2022
Merged
@t3chguy
Copy link
Member

t3chguy commented Mar 23, 2022

Fixed by matrix-org/matrix-js-sdk@3892df8 (#2256)

@MadLittleMods MadLittleMods mentioned this issue Mar 23, 2022
Open
MadLittleMods added a commit to matrix-org/matrix-react-sdk that referenced this issue May 5, 2022
@MadLittleMods
Log TimelinePanel debuggin info when opening the bug report modal
2861486 
To debug all of the timeline problems:

 - element-hq/element-web#21613
 - element-hq/element-web#21922
 - element-hq/element-web#21432
 - element-hq/element-web#21533
@MadLittleMods MadLittleMods mentioned this issue May 5, 2022
Merged
MadLittleMods added a commit to matrix-org/matrix-react-sdk that referenced this issue May 10, 2022
@MadLittleMods
Log TimelinePanel debugging info when opening the bug report modal (#…
3a241e0 
…8502)

To debug all of the timeline problems:

 - element-hq/element-web#21613
 - element-hq/element-web#21922
 - element-hq/element-web#21432
 - element-hq/element-web#21533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Threads A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues with duplicated MatrixEvent objects around threads matrix-org/matrix-js-sdk
2 participants
@MadLittleMods @t3chguy