Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design of call decline and accept buttons not consistent #21493

Closed
luixxiul opened this issue Mar 21, 2022 · 5 comments · Fixed by matrix-org/matrix-react-sdk#8129
Closed

Design of call decline and accept buttons not consistent #21493

luixxiul opened this issue Mar 21, 2022 · 5 comments · Fixed by matrix-org/matrix-react-sdk#8129
Labels
A-VoIP O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect

Comments

@luixxiul
Copy link

Steps to reproduce

  1. Let other people call you on video (or create another account and call yourself with it)

Outcome

What did you expect?

The button design should be consistent.

What happened instead?

after3

  • Button height is not aligned
  • font-weight are different
  • border-radius are different

Operating system

Debian

Browser information

Firefox

URL for webapp

localhost

Application version

develop branch

Homeserver

No response

Will you send logs?

No
@luixxiul
Copy link
Author

The issue is caused with the default border. Fix is ready.

after

@germain-gg germain-gg added S-Tolerable Low/no impact on users A-VoIP O-Occasional Affects or can be seen by some users regularly or most users rarely labels Mar 22, 2022
@luixxiul
Copy link
Author

Should Decline have the same font-weight as Call back here?

@SimonBrandner
Copy link
Contributor

Should Decline have the same font-weight as Call back here?

Both should be 600 say the design specs

How did you manage to get both Decline and Call back displayed? Doesn't seem to be a state that we should have

@luixxiul
Copy link
Author

luixxiul commented Mar 23, 2022 •
edited
Loading

Basically I just modified the code temporarily to display the both types of buttons. I haven't noticed those texts, which are unnatural as you mentioned 😅

Would you please letting me know where the design spec is available?

@luixxiul luixxiul mentioned this issue Mar 23, 2022
Merged
@SimonBrandner
Copy link
Contributor

Basically I just modified the code temporarily to display the both types of buttons. I haven't noticed those texts, which are unnatural as you mentioned sweat_smile

Ah, I see :D

Would you please letting me know where the design spec is available?

They're "semi-private" - I would suggest joining https://matrix.to/#/#element-dev:matrix.org and asking for access there

turt2live pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 4, 2022
@luixxiul
Normalize call buttons (#8129)
631fd87 
- Set a mixin to use it on call events and toasts

Fixes element-hq/element-web#21493

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
kegsay added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 14, 2022
@kegsay
Merge tag 'v3.42.3' into kegan/sync-v3
4efc389 
* Release threads as a beta feature ([\#8081](#8081)). Fixes element-hq/element-web#21351.
* More video rooms design updates ([\#8222](#8222)).
* Update video rooms to new design specs ([\#8207](#8207)). Fixes element-hq/element-web#21515, element-hq/element-web#21516 element-hq/element-web#21519 and element-hq/element-web#21526.
* Live Location Sharing - left panel warning with error ([\#8201](#8201)).
* Live location sharing - Stop publishing location to beacons with consecutive errors ([\#8194](#8194)).
* Live location sharing: allow retry when stop sharing fails ([\#8193](#8193)).
* Allow voice messages to be scrubbed in the timeline ([\#8079](#8079)). Fixes element-hq/element-web#18713.
* Live location sharing - stop sharing to beacons in rooms you left ([\#8187](#8187)).
* Allow sending and thumbnailing AVIF images ([\#8172](#8172)).
* Live location sharing - handle geolocation errors ([\#8179](#8179)).
* Show voice room participants when not connected ([\#8136](#8136)). Fixes element-hq/element-web#21513.
* Add margins between labs sections ([\#8169](#8169)).
* Live location sharing - send geolocation beacon events - happy path ([\#8127](#8127)).
* Add support for Animated (A)PNG ([\#8158](#8158)). Fixes element-hq/element-web#12967.
* Don't form continuations from thread roots ([\#8166](#8166)). Fixes element-hq/element-web#20908.
* Improve handling of animated GIF and WEBP images ([\#8153](#8153)). Fixes element-hq/element-web#16193 and element-hq/element-web#6684.
* Wire up file preview for video files ([\#8140](#8140)). Fixes element-hq/element-web#21539.
* When showing thread, always auto-focus its composer ([\#8115](#8115)). Fixes element-hq/element-web#21438.
* Live location sharing - refresh beacon expiry in room ([\#8116](#8116)).
* Use styled mxids in member list v2 ([\#8110](#8110)). Fixes element-hq/element-web#14825. Contributed by @SimonBrandner.
* Delete groups (legacy communities system) ([\#8027](#8027)). Fixes element-hq/element-web#17532.
* Add a prototype of voice rooms in labs ([\#8084](#8084)). Fixes element-hq/element-web#3546.
* Fix editing `<ol>` tags with a non-1 start attribute ([\#8211](#8211)). Fixes element-hq/element-web#21625.
* Fix URL previews being enabled when room first created ([\#8227](#8227)). Fixes element-hq/element-web#21659.
* Don't use m.call for Jitsi video rooms ([\#8223](#8223)).
* Scale emoji with size of surrounding text ([\#8224](#8224)).
* Make "Jump to date" translatable ([\#8218](#8218)).
* Normalize call buttons ([\#8129](#8129)). Fixes element-hq/element-web#21493. Contributed by @luixxiul.
* Show room preview bar with maximised widgets ([\#8180](#8180)). Fixes element-hq/element-web#21542.
* Update more strings to not wrongly mention room when it is/could be a space ([\#7722](#7722)). Fixes element-hq/element-web#20243 and element-hq/element-web#20910.
* Fix issue with redacting via edit composer flow causing stuck editStates ([\#8184](#8184)).
* Fix some image/video scroll jumps ([\#8182](#8182)).
* Fix "react error on share dialog" ([\#8170](#8170)). Contributed by @yaya-usman.
* Fix disambiguated profile in threads in bubble layout ([\#8168](#8168)). Fixes element-hq/element-web#21570. Contributed by @SimonBrandner.
* Responsive BetaCard on Labs ([\#8154](#8154)). Fixes element-hq/element-web#21554. Contributed by @luixxiul.
* Display button as inline in room directory dialog ([\#8164](#8164)). Fixes element-hq/element-web#21567. Contributed by @luixxiul.
* Null guard TimelinePanel unmount edge ([\#8171](#8171)).
* Fix beta pill label breaking ([\#8162](#8162)). Fixes element-hq/element-web#21566. Contributed by @luixxiul.
* Strip relations when forwarding ([\#7929](#7929)). Fixes element-hq/element-web#19769, element-hq/element-web#18067 element-hq/element-web#21015 and element-hq/element-web#10924.
* Don't try (and fail) to show replies for redacted events ([\#8141](#8141)). Fixes element-hq/element-web#21435.
* Fix 3pid member info for space member list ([\#8128](#8128)). Fixes element-hq/element-web#21534.
* Set max-width to user context menu ([\#8089](#8089)). Fixes element-hq/element-web#21486. Contributed by @luixxiul.
* Fix issue with falsey hrefs being sent in events ([\#8113](#8113)). Fixes element-hq/element-web#21417.
* Make video sizing consistent with images ([\#8102](#8102)). Fixes element-hq/element-web#20072.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-VoIP O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Normalize call buttons
3 participants
@germain-gg @luixxiul @SimonBrandner