Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip on send button in forward dialog is redundant #20630

Closed
robintown opened this issue Jan 19, 2022 · 0 comments · Fixed by matrix-org/matrix-react-sdk#7594
Closed

Tooltip on send button in forward dialog is redundant #20630

robintown opened this issue Jan 19, 2022 · 0 comments · Fixed by matrix-org/matrix-react-sdk#7594
Labels
A-Message-Forwarding O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect

Comments

@robintown
Copy link
Member

Steps to reproduce

  1. Forward a message
  2. Hover over one of the send buttons

Outcome

tooltip

What did you expect?

There should be no tooltip on the send button, since its function is self explanatory.

What happened instead?

The tooltip repeats the same label as the button, and so does not add any helpful information.

Operating system

NixOS unstable

Browser information

Firefox 96.0

URL for webapp

develop.element.io

Application version

Element version: 840867b-react-a00d359422a6-js-652b3a9208f0 Olm version: 3.2.8

Homeserver

townsendandsmith.ml

Will you send logs?

No

@robintown robintown added T-Defect S-Tolerable Low/no impact on users O-Occasional Affects or can be seen by some users regularly or most users rarely A-Message-Forwarding labels Jan 19, 2022
twigleingrid added a commit to twigleingrid/matrix-react-sdk that referenced this issue Jan 21, 2022
Remove tooltip on the send button of the forward dialog
only in the specified case: the button and the tooltip
have the same text string "Send".
Fixes element-hq/element-web#20630

Signed-off by: Ingrid Budau inigiri@posteo.jp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Message-Forwarding O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant