Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji reactions should use the colourful variation-16 selector when available #13926

Closed
ara4n opened this issue Jun 4, 2020 · 2 comments · Fixed by matrix-org/matrix-react-sdk#4707
Labels
Z-Community-PR Issue is solved by a community member's PR

Comments

@ara4n
Copy link
Member

ara4n commented Jun 4, 2020

For emoji in https://unicode.org/emoji/charts/emoji-variants.html, we should prefer sending the colourful variation unless we are very deliberately sending a black and white one. This is more correct than leaving it ambiguous by missing off the selector, where some platforms may assume you meant the black and white variant.

@ara4n
Copy link
Member Author

ara4n commented Jun 4, 2020

In practice this means ensuring that the ambiguous emoji end with a \uFE0F variation selector. emojibase-data 5 dues this automatically for us, but need to ensure that the quick-reaction presets to this too.

(This would solve #13586)

@t3chguy
Copy link
Member

t3chguy commented Jun 4, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants