Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can react twice with the same emoji #13586

Closed
tredondo opened this issue May 7, 2020 · 4 comments
Closed

Can react twice with the same emoji #13586

tredondo opened this issue May 7, 2020 · 4 comments
Labels
A-Reactions T-Defect Z-Community-PR Issue is solved by a community member's PR

Comments

@tredondo
Copy link

tredondo commented May 7, 2020

You can react to the same message with the same reaction twice: once by choosing the emoji from the picker, and once from the Quick Reactions. But if you hover over them, they show the same code.

image

Riot 1.6 web.

@turt2live
Copy link
Member

Duplicate of #11161

@t3chguy
Copy link
Member

t3chguy commented May 7, 2020

This is not the same. That issue is duplicated counts within a key, this is unprintable unicode chars not being filtered out so they key differently.

@dud1337
Copy link

dud1337 commented Jun 4, 2020

Edit: Perhaps this is feature to enable "two thumbs up/down"-ing 😺

Not all quick reactions have this bug.

Buggy:

  • :thumbsup:
  • :thumbsdown:

Safe:

  • :happy:
  • :tada:
  • :confused:
  • :heart:
  • :rocket:
  • :eyes:

pic
A quick way to test UI-wise is by selecting, say, :happy: from quick-reactions, then searching for it in the main selector, and seeing it already selected. (Light blue underline in image above)

Then repeat the process for :thumbsup:. One will see it is not selected in the selector. (Pink underline in image above)

@t3chguy
Copy link
Member

t3chguy commented Jun 4, 2020

This is now fixed on develop by matrix-org/matrix-react-sdk#4707 for outbound reactions. If you click on an existing reaction which has some invisible unicode then riot will match that invisible unicode and thus you could end up with loads of mismatched thumbs up.

@t3chguy t3chguy closed this as completed Jun 4, 2020
@t3chguy t3chguy added the Z-Community-PR Issue is solved by a community member's PR label Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Reactions T-Defect Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

No branches or pull requests

5 participants