Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't disable inline URL previews in user settings #12339

Closed
jdm opened this issue Feb 12, 2020 · 5 comments
Closed

Can't disable inline URL previews in user settings #12339

jdm opened this issue Feb 12, 2020 · 5 comments
Labels
A-User-Settings T-Defect Z-Mozilla

Comments

@jdm
Copy link

jdm commented Feb 12, 2020

Description

Toggling the "Enable inline URL previews by default" option does not preserve the new value when closing the settings windows.

Steps to reproduce

  • open the user settings dialog
  • go to the preferences tab
  • toggle "Enable inline URL previews by default"
  • press the X to close the settings window
  • open the user settings dialog
  • go to the preferences tab

Instead of display the new toggled value that I chose, I see the original value from before I toggled it. Other preferences retain their toggled values without any difficulty.

Logs being sent: no

Before toggling:
Screen Shot 2020-02-12 at 9 07 39 AM
After toggling:
Screen Shot 2020-02-12 at 9 07 46 AM
After closing and reopening the settings:
Screen Shot 2020-02-12 at 9 07 53 AM

Version information

  • Platform: web (in-browser)

For the web app:

  • Browser: Firefox 74 nightly
  • OS: macOS
  • URL: chat.mozilla.org
@jdm jdm added the T-Defect label Feb 12, 2020
@SeerLite
Copy link

Getting the same issue on the Desktop version on Linux. I want to enable it however, it reverts to disabled when closing.

@SimonBrandner SimonBrandner mentioned this issue Jan 21, 2021
Closed
@SimonBrandner
Copy link
Contributor

@jdm Are you still able to reproduce this on a non-matrix.org server? I am not

@SeerLite On which server are you? If it's matrix.org, it might be a global server problem

@SimonBrandner
Copy link
Contributor

Also note that for end-to-end encrypted rooms you have to enable it, in the room settings

@SeerLite
Copy link

Sorry, I got confused, I didn't have this exact issue. I was having the problem with the URL previews in the room settings on E2E chats, not the user settings.
I'm not having the issue anymore though, it's working fine on matrix.org. You may have been right about it being a server problem (that got fixed?). Thanks

@jryans
Copy link
Collaborator

jryans commented Jan 25, 2021

I believe this is an operational issue that should now be fixed. If others are seeing this, please check with your homeserver admin.

@jryans jryans closed this as completed Jan 25, 2021
t3chguy pushed a commit that referenced this issue Oct 17, 2024
@florianduros
Update @vector-im/compound-design-tokens in package.json (#12339)
e3ba643
JohnSimonsen pushed a commit to verji/element-web-v2 that referenced this issue Dec 20, 2024
@thoraj @florianduros
@dbkr @richvdh @RiotRobot @robintown
Get upstream changes via verji#develop (element-hq#13)
de3a9bc 
* Update `@vector-im/compound-design-tokens` in package.json (element-hq#12339)

* Change 'type' prop on badges to 'forceDot' (element-hq#12327)

* Change 'type' prop on badges tio 'forceDot'

Which, hopefully, better represents what it actually does. Tidies
up some of the logic.

Split out from matrix-org/matrix-react-sdk#12254

* Missed a file

* More comments

* Oops, there is no count here.

* Back out the logic refactor of StatelessNotificationBadge

because it was also updating the logic for mark as unread badges and
rewriting the ternary to the previous logic would be quite complex.

* Fix doc comment

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

* Clarify doc on displaying the count

* Update doc for the forceDot param here too.

---------

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

* [Backport staging] Update `@vector-im/compound-design-tokens` in package.json (element-hq#12340)

(cherry picked from commit e3ba643)

Co-authored-by: Florian Duros <florianduros@element.io>

* Fix the image view (element-hq#12341)

* TAC: Fix hover state when expanded (element-hq#12337)

* Fix TAC hover state

* Add playwright test

* Update playwright snapshot after last compound style changes

* v3.95.0-rc.0

* v3.95.0

* Reset matrix-js-sdk back to develop branch

* TAC: Order rooms by most recent after notification level (element-hq#12329)

* Order room by thread timestamp

* Fix key errors in test

* Update jest snapshots

* Update snapshots

* Rename alpha/beta to numbers

* Add playwright test

* Replace forceCount prop with hideIfDot (element-hq#12344)

This replaces the `forceCount` prop on room badge components with
`hideIfDot` which hopefully gives a better idea of what it does,
since forceCount did not really force a count. Also remove the
prop where it was just passing the default value anyway.

---------

Co-authored-by: Florian Duros <florianduros@element.io>
Co-authored-by: David Baker <dbkr@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: ElementRobot <releases@riot.im>
Co-authored-by: Robin <robin@robin.town>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-User-Settings T-Defect Z-Mozilla
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jdm @jryans @aaronraimist @SeerLite @SimonBrandner