Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header markdown does not display correctly apart from # (<h1>) #1417

Open
kittykat opened this issue Oct 29, 2021 · 7 comments
Open

Header markdown does not display correctly apart from # (<h1>) #1417

kittykat opened this issue Oct 29, 2021 · 7 comments
Assignees
Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design Z-Confidence-High High confidence in the enhancement or suggestion based on known factors, or as described.

Comments

@kittykat
Copy link
Contributor

kittykat commented Oct 29, 2021

Steps to reproduce

  1. Send this message:
# Header
## Subheader
### Sub-subheader

Outcome

What did you expect?

Headings displaying in hierarchical formatting

What happened instead?

Screenshot from 2021-10-29 12-59-31

{
  "type": "m.room.message",
  "content": {
    "msgtype": "m.text",
    "body": "# Header\n## Subheader\n### Sub-subheader",
    "format": "org.matrix.custom.html",
    "formatted_body": "<h1>Header</h1>\n<h2>Subheader</h2>\n<h3>Sub-subheader</h3>\n"
  }
}

URL for webapp

develop.element.io

Application version

Element version: ba302b7dc068-react-3defb863b35b-js-14e008bbad18 Olm version: 3.2.3

@kittykat kittykat added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Oct 29, 2021
@kittykat kittykat changed the title Header markdown does not display correctly apart from # Header markdown does not display correctly apart from # (<h1>) Oct 29, 2021
@t3chguy
Copy link
Member

t3chguy commented Oct 29, 2021

We intentionally render h1 & h2 as a h3 to prevent the scale being far too large.

@t3chguy t3chguy added the X-Needs-Product More input needed from the Product team label Oct 29, 2021
@kittykat
Copy link
Contributor Author

I would expect h3 to be rendered much smaller than it does at the moment. The current render matches my expectation for h1.

@novocaine novocaine added X-Needs-Design and removed X-Needs-Product More input needed from the Product team labels Nov 1, 2021
@Palid
Copy link

Palid commented Nov 16, 2021

@janogarcia is working on normalizing the markdown headers between all the applications versions, so this issue will be blocked for a while longer and work on it will only begun after it's normalized.

@JeanPaulLucien
Copy link

If you like this I can make a PR. Just tell me where style is.

image

@t3chguy
Copy link
Member

t3chguy commented Feb 24, 2023

@JeanPaulLucien I suggest reading the history of the issue. #1417

@JeanPaulLucien
Copy link

the scale being far too large.

Will not.

@t3chguy
Copy link
Member

t3chguy commented Feb 24, 2023

@JeanPaulLucien that call is up to the design team at Element

@t3chguy t3chguy transferred this issue from element-hq/element-web Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design Z-Confidence-High High confidence in the enhancement or suggestion based on known factors, or as described.
Projects
None yet
Development

No branches or pull requests

6 participants