Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message Bubbles: Layout for Media (part 1) #5419

Merged
merged 14 commits into from
Jan 25, 2022
Merged

Message Bubbles: Layout for Media (part 1) #5419

merged 14 commits into from
Jan 25, 2022

Conversation

SBiOSoftWhare
Copy link
Contributor

@SBiOSoftWhare SBiOSoftWhare commented Jan 21, 2022 •
edited
Loading

Part of #5209

Handles:

  • Emote
  • Outgoing image
  • Files

Simulator Screen Shot - iPhone 13 - 2022-01-24 at 14 53 24

@github-actions
Copy link

github-actions bot commented Jan 21, 2022 •
edited
Loading

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/nV7jaz

@SBiOSoftWhare SBiOSoftWhare changed the title Message Bubbles: Layout for Media Message Bubbles: Layout for Media (part 1) Jan 24, 2022
pixlwave
pixlwave approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (presuming roomScreenAllowTimelineStyleConfiguration is going to be reverted before merging).

langleyd added a commit that referenced this pull request Jan 24, 2022
@langleyd
Fix missing bubbles cell types (from #5419)
c2928ba
@SBiOSoftWhare SBiOSoftWhare merged commit 07107d3 into develop Jan 25, 2022
@SBiOSoftWhare SBiOSoftWhare deleted the steve/5209_media_bubbles branch January 25, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SBiOSoftWhare @pixlwave