Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalinks to a matrix user should be pills #7411

Closed
giomfo opened this issue Mar 6, 2023 · 1 comment
Closed

Permalinks to a matrix user should be pills #7411

giomfo opened this issue Mar 6, 2023 · 1 comment
Assignees
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@giomfo
Copy link
Member

giomfo commented Mar 6, 2023

Steps to reproduce

Send in a room the following permalink : "https://matrix.to/#/@sddfshfjkashfk:matrix.org"

Outcome

What did you expect?

a pill with the user's name and profile picture if any. Like this: Screenshot 2023-02-21 at 18 09 52
If this is not possible, the pill should show the default user icon and the mxId : image

What happened instead?

The matrix.to url is displayed
image

Will you send logs?

No

@giomfo giomfo added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Mar 6, 2023
@giomfo giomfo changed the title Permalinks to a user should be pills Permalinks to a matrix user should be pills Mar 6, 2023
@giomfo giomfo added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Mar 7, 2023
nimau added a commit that referenced this issue Mar 17, 2023
#7409: Permalinks to a room/space are pillified
#7411: Permalinks to a matrix user are pillified
#7412: Permalinks to messages are pillified
nimau added a commit that referenced this issue Mar 17, 2023
#7409: Permalinks to a room/space are pillified
#7411: Permalinks to a matrix user are pillified
#7412: Permalinks to messages are pillified
@giomfo
Copy link
Member Author

giomfo commented Mar 22, 2023

Done v1.10.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

No branches or pull requests

2 participants