typescript src/room
#437
Merged
typescript src/room
#437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toger5
commented
Jul 4, 2022
|
|
||
| useEffect(() => { | ||
| setState({ json: state }); | ||
| setState(state); |
There was a problem hiding this comment.
why was it done with the {json: ...} before? Should the useState be changed to:
useState({json: {}} as {json: State});
There was a problem hiding this comment.
Yeah, not sure - would have to ask @robertlong, although I'd probably just remove the json
src src/settings src/auth
dbkr
reviewed
Jul 8, 2022
|
|
||
| useEffect(() => { | ||
| setState({ json: state }); | ||
| setState(state); |
There was a problem hiding this comment.
Yeah, not sure - would have to ask @robertlong, although I'd probably just remove the json
(this depends on: matrix-org/matrix-js-sdk#2527)
dbkr
reviewed
Jul 19, 2022
src/room/GroupCallInspector.tsx
Outdated
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| const [context, _] = useState< | ||
| [State, React.Dispatch<React.SetStateAction<State>>] | ||
| >([{}, () => {}]); |
There was a problem hiding this comment.
Did you work out what was going on here? How does the context get set, and what's the weird value provided to the initialiser?
There was a problem hiding this comment.
I added a comment where the context gets set. I also fixed the initial value.
dbkr
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reviewers:
@types/react-router-domare there any conventions I have to follow for adding packages?Depends on:
Add missing events from reemitter to GroupCall matrix-org/matrix-js-sdk#2527