Fix rust crypto: Don't use legacy cryptoStore anymore.
#2587
Conversation
The logic with the legacy store was intercepting with the rustCrypto that handles all the cases itself.
toger5
force-pushed
the
toger5/fix-rust-crypto
branch
from
4889839 to
71ff070
Compare
toger5
force-pushed
the
toger5/fix-rust-crypto
branch
from
71ff070 to
01ad4fe
Compare
| try { | ||
| await client.store.startup(); | ||
| } catch (error) { | ||
| logger.error( | ||
| "Error starting matrix client store. Falling back to memory store.", | ||
| error, | ||
| ); | ||
| client.store = new MemoryStore({ localStorage }); | ||
| await client.store.startup(); |
There was a problem hiding this comment.
Ah. You've fallen into the trap of confusing client.store with client.cryptoStore. This is an understandable mistake, because the name is unclear and the documentation is, well, about as good as the rest of the documentation for the js-sdk.
client.store is used to stash things like sync results. It's totally independent of the cryptostore, and uses a separate indexeddb database.
Anyway, calling client.store.startup() is important, and you need to keep this, otherwise client.startClient() will hang. (You might reasonably ask why client.startClient doesn't call store.startup() itself. I don't know.)
There was a problem hiding this comment.
Thank you so much Rich!!
This would have been a debugging session to fix this without your comment.
🙏
The logic with the legacy store was intercepting with the `rustCrypto that handles all the cases itself.