Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fkwp/cleanup config #2498

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Fkwp/cleanup config #2498

merged 3 commits into from
Jul 24, 2024

Conversation

fkwp
Copy link
Contributor

@fkwp fkwp commented Jul 24, 2024

No description provided.

@fkwp fkwp requested a review from a team as a code owner July 24, 2024 10:20
toger5
toger5 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes so much more sense (calling it netlify).

I have one question about the complete removal of develop.
If that is intentional and easy to answer feel free to merge.

config/element_io_develop.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not used anymore? Because this is maintained in elements config repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its not used anymore since we use the docker image for our deployments

@toger5
Copy link
Contributor

toger5 commented Jul 24, 2024

I took the liberty to run prettier on the changes.

@fkwp fkwp merged commit 78f4c2a into livekit Jul 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toger5 toger5 toger5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fkwp @toger5