Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Member count doesn't decrease immediately #1763

Closed
dbkr opened this issue Oct 13, 2023 · 1 comment · Fixed by matrix-org/matrix-js-sdk#3799
Closed

Member count doesn't decrease immediately #1763

dbkr opened this issue Oct 13, 2023 · 1 comment · Fixed by matrix-org/matrix-js-sdk#3799
Labels
T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems

Comments

@dbkr
Copy link
Member

dbkr commented Oct 13, 2023

Steps to reproduce

  1. Join video call from one client
  2. Join from another
  3. Leave from either

Outcome

What did you expect?

Member count of the client you still have joined should be 1

What happened instead?

It's still 2, at least for a little while.

Operating system

No response

Browser information

No response

URL for webapp

No response

Will you send logs?

No
@dbkr dbkr added the T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems label Oct 13, 2023
@dbkr
Copy link
Member Author

dbkr commented Oct 13, 2023

Regressed by matrix-org/matrix-js-sdk#3756 I think

dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue Oct 13, 2023
@dbkr
Fix sending call member events on leave
ea680da 
#3756 changed
the membership update function to await on the next call, but this
meant it never returned and therefore never cleared
`updateCallMembershipRunning`. We therefore didn't send the updated
call member event when leaving, instead sending it whenever the next
poll interval arrived.

This changes it to only await if we are retrying, not if we're just
scheduling the next poll.

Fixes element-hq/element-call#1763
dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue Oct 13, 2023
@dbkr
Fix sending call member events on leave
f29b45d 
#3756 changed
the membership update function to await on the next call, but this
meant it never returned and therefore never cleared
`updateCallMembershipRunning`. We therefore didn't send the updated
call member event when leaving, instead sending it whenever the next
poll interval arrived.

This changes it to only await if we are retrying, not if we're just
scheduling the next poll.

Fixes element-hq/element-call#1763
@dbkr dbkr mentioned this issue Oct 13, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit to matrix-org/matrix-js-sdk that referenced this issue Oct 17, 2023
@dbkr
Fix sending call member events on leave (#3799)
4ce837b 
#3756 changed
the membership update function to await on the next call, but this
meant it never returned and therefore never cleared
`updateCallMembershipRunning`. We therefore didn't send the updated
call member event when leaving, instead sending it whenever the next
poll interval arrived.

This changes it to only await if we are retrying, not if we're just
scheduling the next poll.

Fixes element-hq/element-call#1763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sending call member events on leave matrix-org/matrix-js-sdk
1 participant
@dbkr