-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics for IA project #5399
metrics for IA project #5399
Conversation
@@ -117,6 +121,7 @@ class CreateDirectRoomViewModel @AssistedInject constructor(@Assisted | |||
val result = runCatchingToAsync { | |||
session.createRoom(roomParams) | |||
} | |||
analyticsTracker.capture(CreatedRoom(isDM = roomParams.isDirect.orFalse())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to double check, do we want to only track successful room creation or all attempts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK attempts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small question about the create room tracking, otherwise looking good! 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 small remarks, else LGTM.
vector/src/main/java/im/vector/app/features/roomprofile/RoomProfileFragment.kt
Outdated
Show resolved
Hide resolved
vector/src/main/res/layout/fragment_matrix_to_room_space_card.xml
Outdated
Show resolved
Hide resolved
# Conflicts: # vector/src/main/java/im/vector/app/features/createdirect/CreateDirectRoomViewModel.kt
closes #5013