tracking number of spaces user joined #5300

fedrunov · 2022-02-22T13:13:14Z

github-actions · 2022-02-22T13:44:30Z

Unit Test Results

110 files +12 110 suites +12 1m 18s ⏱️ +13s
195 tests +17 195 ✔️ +17 0 💤 ±0 0 ❌ ±0
650 runs +66 650 ✔️ +66 0 💤 ±0 0 ❌ ±0

Results for commit 87df7a9. ± Comparison against base commit 5de7873.

This pull request removes 12 and adds 29 tests. Note that renamed tests count towards both.

im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given a selected picture when handling save selected profile picture then updates upstream avatar and completes personalization
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given changing profile picture is not supported when updating display name then updates upstream user display name and completes personalization
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given changing profile picture is supported when updating display name then updates upstream user display name and moves to choose profile picture
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given homeserver does not support personalisation when registering account then updates state and emits account created event
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given no selected picture when saving selected profile picture then emits failure event
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given only supports changing profile picture when handling PersonalizeProfile then emits contents choose profile picture
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given supports changing display name when handling PersonalizeProfile then emits contents choose display name
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given upstream failure when handling display name update then emits failure event
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given upstream update avatar fails when saving selected profile picture then emits failure event
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ when handling PostViewEvent then emits contents as view event
…

im.vector.app.features.location.LocationDataTest ‑ unstablePrefixTest
im.vector.app.features.location.domain.usecase.CompareLocationsUseCaseTest ‑ given 2 far away locations when calling execute then these locations are considered as not equal
im.vector.app.features.location.domain.usecase.CompareLocationsUseCaseTest ‑ given 2 very near locations when calling execute then these locations are considered as equal
im.vector.app.features.onboarding.DirectLoginUseCaseTest ‑ given direct authentication throws, when logging in directly, then returns failure result with original cause
im.vector.app.features.onboarding.DirectLoginUseCaseTest ‑ given wellknown fails with content, when logging in directly, then returns success with direct session result
im.vector.app.features.onboarding.DirectLoginUseCaseTest ‑ given wellknown fails without content, when logging in directly, then returns well known error
im.vector.app.features.onboarding.DirectLoginUseCaseTest ‑ given wellknown throws, when logging in directly, then returns failure result with original cause
im.vector.app.features.onboarding.DirectLoginUseCaseTest ‑ when logging in directly, then returns success with direct session result
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given a selected picture, when handling save selected profile picture, then updates upstream avatar and completes personalization
im.vector.app.features.onboarding.OnboardingViewModelTest ‑ given changing profile picture is not supported, when updating display name, then updates upstream user display name and completes personalization
…

♻️ This comment has been updated with latest results.

github-actions · 2022-02-22T13:51:50Z

Matrix SDK

Integration Tests Results:

[org.matrix.android.sdk.session]
passed=
[org.matrix.android.sdk.account]
passed=
[org.matrix.android.sdk.internal]
passed=
[org.matrix.android.sdk.ordering]
passed=
[org.matrix.android.sdk.PermalinkParserTest]
passed=

bmarty

Some thoughts about the implementation

...dk-android/src/main/java/org/matrix/android/sdk/internal/session/sync/SyncResponseHandler.kt

matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/Session.kt

ouchadam · 2022-04-04T08:34:36Z

vector/src/main/java/im/vector/app/AppStateHandler.kt

+    private fun observeSyncStatus(session: Session) {
+        session.getSyncStatusLive()
+                .asFlow()
+                .filterIsInstance<SyncStatusService.Status.IncrementalSyncDone>()


we can use Flow.distinct to avoid keeping track of the previous state https://github.com/vector-im/element-android/pull/5300/files#diff-d5584663de96dcd881e4441839a2a6e44b50a58268b0b9af4d17be21fba9897fR152

👍 added one line below

ganfra · 2022-04-04T17:04:50Z

vector/src/main/java/im/vector/app/AppStateHandler.kt

+                .filterIsInstance<SyncStatusService.Status.IncrementalSyncDone>()
+                .onEach {
+                    handleJoinedSpaceStatistics(session.spaceService().getRootSpaceSummaries().size)
+                }.launchIn(session.coroutineScope)


This is going to subscribe each time you switch space, no?

Why do you think so? observeSyncStatus called when session is changed and it subscribes to a sync status.

check the latest changes, it's now a little bit different

ouchadam

LGTM! will leave to @ganfra (and confirming the space switching behaviour)

ganfra

Ok, LGTM now, thanks

tracking number of spaces user joined

b4ce933

bmarty reviewed Feb 23, 2022

View reviewed changes

...dk-android/src/main/java/org/matrix/android/sdk/internal/session/sync/SyncResponseHandler.kt Outdated Show resolved Hide resolved

matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/Session.kt Outdated Show resolved Hide resolved

fedrunov self-assigned this Mar 15, 2022

NIkita Fedrunov added 3 commits March 15, 2022 09:36

changes according to code review

a943eda

Merge branch 'develop' into feature/nfe/joined_spaces_tracking

07807bf

removed obsolete code

c932b96

fedrunov requested review from ganfra, bmarty and ouchadam April 4, 2022 08:32

ouchadam reviewed Apr 4, 2022

View reviewed changes

ganfra reviewed Apr 4, 2022

View reviewed changes

changed according to code review

5c4753c

fedrunov requested a review from ouchadam April 5, 2022 07:55

another round of code review

87df7a9

ouchadam approved these changes Apr 5, 2022

View reviewed changes

fedrunov requested a review from ganfra April 6, 2022 07:50

ganfra approved these changes Apr 6, 2022

View reviewed changes

fedrunov merged commit 504a242 into develop Apr 7, 2022

fedrunov deleted the feature/nfe/joined_spaces_tracking branch April 7, 2022 14:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tracking number of spaces user joined #5300

tracking number of spaces user joined #5300

fedrunov commented Feb 22, 2022

github-actions bot commented Feb 22, 2022 •

edited

Loading

github-actions bot commented Feb 22, 2022

bmarty left a comment

ouchadam Apr 4, 2022 •

edited

Loading

fedrunov Apr 5, 2022

ganfra Apr 4, 2022

fedrunov Apr 5, 2022

fedrunov Apr 5, 2022 •

edited

Loading

ouchadam left a comment

ganfra left a comment

tracking number of spaces user joined #5300

tracking number of spaces user joined #5300

Conversation

fedrunov commented Feb 22, 2022

github-actions bot commented Feb 22, 2022 • edited Loading

Unit Test Results

github-actions bot commented Feb 22, 2022

Matrix SDK

Integration Tests Results:

bmarty left a comment

Choose a reason for hiding this comment

ouchadam Apr 4, 2022 • edited Loading

Choose a reason for hiding this comment

fedrunov Apr 5, 2022

Choose a reason for hiding this comment

ganfra Apr 4, 2022

Choose a reason for hiding this comment

fedrunov Apr 5, 2022

Choose a reason for hiding this comment

fedrunov Apr 5, 2022 • edited Loading

Choose a reason for hiding this comment

ouchadam left a comment

Choose a reason for hiding this comment

ganfra left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 22, 2022 •

edited

Loading

ouchadam Apr 4, 2022 •

edited

Loading

fedrunov Apr 5, 2022 •

edited

Loading