Remove exceptions from lambda security configuration

Fixes: spring-projectsgh-7128

config/src/main/java/org/springframework/security/config/Customizer.java

@@ -17,8 +17,7 @@
 package org.springframework.security.config;
 
 /**
- * Callback interface that accepts a single input argument and returns no result,
- * with the ability to throw a (checked) exception.
+ * Callback interface that accepts a single input argument and returns no result.
  *
  * @author Eleftheria Stein
  * @param <T> the type of the input to the operation
@@ -31,9 +30,8 @@ public interface Customizer<T> {
 	 * Performs the customizations on the input argument.
 	 *
 	 * @param t the input argument
-	 * @throws Exception if any error occurs
 	 */
-	void customize(T t) throws Exception;
+	void customize(T t);
 
 	/**
 	 * Returns a {@link Customizer} that does not alter the input argument.

config/src/main/java/org/springframework/security/config/annotation/web/configurers/HeadersConfigurer.java

@@ -136,10 +136,8 @@ public ContentTypeOptionsConfig contentTypeOptions() {
 	 * @param contentTypeOptionsCustomizer the {@link Customizer} to provide more options for
 	 * the {@link ContentTypeOptionsConfig}
 	 * @return the {@link HeadersConfigurer} for additional customizations
-	 * @throws Exception
 	 */
-	public HeadersConfigurer<H> contentTypeOptions(Customizer<ContentTypeOptionsConfig> contentTypeOptionsCustomizer)
-			throws Exception {
+	public HeadersConfigurer<H> contentTypeOptions(Customizer<ContentTypeOptionsConfig> contentTypeOptionsCustomizer) {
 		contentTypeOptionsCustomizer.customize(contentTypeOptions.enable());
 		return HeadersConfigurer.this;
 	}
@@ -209,9 +207,8 @@ public XXssConfig xssProtection() {
 	 * @param xssCustomizer the {@link Customizer} to provide more options for
 	 * the {@link XXssConfig}
 	 * @return the {@link HeadersConfigurer} for additional customizations
-	 * @throws Exception
 	 */
-	public HeadersConfigurer<H> xssProtection(Customizer<XXssConfig> xssCustomizer) throws Exception {
+	public HeadersConfigurer<H> xssProtection(Customizer<XXssConfig> xssCustomizer) {
 		xssCustomizer.customize(xssProtection.enable());
 		return HeadersConfigurer.this;
 	}
@@ -322,14 +319,12 @@ public CacheControlConfig cacheControl() {
 	 * @param cacheControlCustomizer the {@link Customizer} to provide more options for
 	 * the {@link CacheControlConfig}
 	 * @return the {@link HeadersConfigurer} for additional customizations
-	 * @throws Exception
 	 */
-	public HeadersConfigurer<H> cacheControl(Customizer<CacheControlConfig> cacheControlCustomizer) throws Exception {
+	public HeadersConfigurer<H> cacheControl(Customizer<CacheControlConfig> cacheControlCustomizer) {
 		cacheControlCustomizer.customize(cacheControl.enable());
 		return HeadersConfigurer.this;
 	}
 
-
 	public final class CacheControlConfig {
 		private CacheControlHeadersWriter writer;
 
@@ -389,9 +384,8 @@ public HstsConfig httpStrictTransportSecurity() {
 	 * @param hstsCustomizer the {@link Customizer} to provide more options for
 	 * the {@link HstsConfig}
 	 * @return the {@link HeadersConfigurer} for additional customizations
-	 * @throws Exception
 	 */
-	public HeadersConfigurer<H> httpStrictTransportSecurity(Customizer<HstsConfig> hstsCustomizer) throws Exception {
+	public HeadersConfigurer<H> httpStrictTransportSecurity(Customizer<HstsConfig> hstsCustomizer) {
 		hstsCustomizer.customize(hsts.enable());
 		return HeadersConfigurer.this;
 	}
@@ -523,9 +517,8 @@ public FrameOptionsConfig frameOptions() {
 	 * @param frameOptionsCustomizer the {@link Customizer} to provide more options for
 	 * the {@link FrameOptionsConfig}
 	 * @return the {@link HeadersConfigurer} for additional customizations
-	 * @throws Exception
 	 */
-	public HeadersConfigurer<H> frameOptions(Customizer<FrameOptionsConfig> frameOptionsCustomizer) throws Exception {
+	public HeadersConfigurer<H> frameOptions(Customizer<FrameOptionsConfig> frameOptionsCustomizer) {
 		frameOptionsCustomizer.customize(frameOptions.enable());
 		return HeadersConfigurer.this;
 	}
@@ -613,9 +606,8 @@ public HpkpConfig httpPublicKeyPinning() {
 	 * @param hpkpCustomizer the {@link Customizer} to provide more options for
 	 * the {@link HpkpConfig}
 	 * @return the {@link HeadersConfigurer} for additional customizations
-	 * @throws Exception
 	 */
-	public HeadersConfigurer<H> httpPublicKeyPinning(Customizer<HpkpConfig> hpkpCustomizer) throws Exception {
+	public HeadersConfigurer<H> httpPublicKeyPinning(Customizer<HpkpConfig> hpkpCustomizer) {
 		hpkpCustomizer.customize(hpkp.enable());
 		return HeadersConfigurer.this;
 	}
@@ -840,10 +832,8 @@ public ContentSecurityPolicyConfig contentSecurityPolicy(String policyDirectives
 	 * @param contentSecurityCustomizer the {@link Customizer} to provide more options for
 	 * the {@link ContentSecurityPolicyConfig}
 	 * @return the {@link HeadersConfigurer} for additional customizations
-	 * @throws Exception
 	 */
-	public HeadersConfigurer<H> contentSecurityPolicy(Customizer<ContentSecurityPolicyConfig> contentSecurityCustomizer)
-			throws Exception {
+	public HeadersConfigurer<H> contentSecurityPolicy(Customizer<ContentSecurityPolicyConfig> contentSecurityCustomizer) {
 		this.contentSecurityPolicy.writer = new ContentSecurityPolicyHeaderWriter();
 		contentSecurityCustomizer.customize(this.contentSecurityPolicy);
 
@@ -1026,9 +1016,8 @@ public ReferrerPolicyConfig referrerPolicy(ReferrerPolicy policy) {
 	 * @param referrerPolicyCustomizer the {@link Customizer} to provide more options for
 	 * the {@link ReferrerPolicyConfig}
 	 * @return the {@link HeadersConfigurer} for additional customizations
-	 * @throws Exception
 	 */
-	public HeadersConfigurer<H> referrerPolicy(Customizer<ReferrerPolicyConfig> referrerPolicyCustomizer) throws Exception {
+	public HeadersConfigurer<H> referrerPolicy(Customizer<ReferrerPolicyConfig> referrerPolicyCustomizer) {
 		this.referrerPolicy.writer = new ReferrerPolicyHeaderWriter();
 		referrerPolicyCustomizer.customize(this.referrerPolicy);
 		return HeadersConfigurer.this;

config/src/main/java/org/springframework/security/config/annotation/web/configurers/HttpBasicConfigurer.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -113,9 +113,8 @@ public HttpBasicConfigurer() throws Exception {
 	 *
 	 * @param realmName the HTTP Basic realm to use
 	 * @return {@link HttpBasicConfigurer} for additional customization
-	 * @throws Exception
 	 */
-	public HttpBasicConfigurer<B> realmName(String realmName) throws Exception {
+	public HttpBasicConfigurer<B> realmName(String realmName) {
 		this.basicAuthEntryPoint.setRealmName(realmName);
 		this.basicAuthEntryPoint.afterPropertiesSet();
 		return this;

config/src/main/java/org/springframework/security/config/annotation/web/configurers/SessionManagementConfigurer.java

@@ -257,8 +257,7 @@ public SessionFixationConfigurer sessionFixation() {
 	 * the {@link SessionFixationConfigurer}
 	 * @return the {@link SessionManagementConfigurer} for further customizations
 	 */
-	public SessionManagementConfigurer<H> sessionFixation(Customizer<SessionFixationConfigurer> sessionFixationCustomizer)
-			throws Exception {
+	public SessionManagementConfigurer<H> sessionFixation(Customizer<SessionFixationConfigurer> sessionFixationCustomizer) {
 		sessionFixationCustomizer.customize(new SessionFixationConfigurer());
 		return this;
 	}
@@ -282,8 +281,7 @@ public ConcurrencyControlConfigurer maximumSessions(int maximumSessions) {
 	 * the {@link ConcurrencyControlConfigurer}
 	 * @return the {@link SessionManagementConfigurer} for further customizations
 	 */
-	public SessionManagementConfigurer<H> sessionConcurrency(Customizer<ConcurrencyControlConfigurer> sessionConcurrencyCustomizer)
-			throws Exception {
+	public SessionManagementConfigurer<H> sessionConcurrency(Customizer<ConcurrencyControlConfigurer> sessionConcurrencyCustomizer) {
 		sessionConcurrencyCustomizer.customize(new ConcurrencyControlConfigurer());
 		return this;
 	}

config/src/main/java/org/springframework/security/config/annotation/web/configurers/oauth2/client/OAuth2LoginConfigurer.java

@@ -208,10 +208,8 @@ public AuthorizationEndpointConfig authorizationEndpoint() {
 	 * @param authorizationEndpointCustomizer the {@link Customizer} to provide more options for
 	 * the {@link AuthorizationEndpointConfig}
 	 * @return the {@link OAuth2LoginConfigurer} for further customizations
-	 * @throws Exception
 	 */
-	public OAuth2LoginConfigurer<B> authorizationEndpoint(Customizer<AuthorizationEndpointConfig> authorizationEndpointCustomizer)
-			throws Exception {
+	public OAuth2LoginConfigurer<B> authorizationEndpoint(Customizer<AuthorizationEndpointConfig> authorizationEndpointCustomizer) {
 		authorizationEndpointCustomizer.customize(this.authorizationEndpointConfig);
 		return this;
 	}
@@ -291,8 +289,7 @@ public TokenEndpointConfig tokenEndpoint() {
 	 * @return the {@link OAuth2LoginConfigurer} for further customizations
 	 * @throws Exception
 	 */
-	public OAuth2LoginConfigurer<B> tokenEndpoint(Customizer<TokenEndpointConfig> tokenEndpointCustomizer)
-			throws Exception {
+	public OAuth2LoginConfigurer<B> tokenEndpoint(Customizer<TokenEndpointConfig> tokenEndpointCustomizer) {
 		tokenEndpointCustomizer.customize(this.tokenEndpointConfig);
 		return this;
 	}
@@ -345,10 +342,8 @@ public RedirectionEndpointConfig redirectionEndpoint() {
 	 * @param redirectionEndpointCustomizer the {@link Customizer} to provide more options for
 	 * the {@link RedirectionEndpointConfig}
 	 * @return the {@link OAuth2LoginConfigurer} for further customizations
-	 * @throws Exception
 	 */
-	public OAuth2LoginConfigurer<B> redirectionEndpoint(Customizer<RedirectionEndpointConfig> redirectionEndpointCustomizer)
-			throws Exception {
+	public OAuth2LoginConfigurer<B> redirectionEndpoint(Customizer<RedirectionEndpointConfig> redirectionEndpointCustomizer) {
 		redirectionEndpointCustomizer.customize(this.redirectionEndpointConfig);
 		return this;
 	}
@@ -399,10 +394,8 @@ public UserInfoEndpointConfig userInfoEndpoint() {
 	 * @param userInfoEndpointCustomizer the {@link Customizer} to provide more options for
 	 * the {@link UserInfoEndpointConfig}
 	 * @return the {@link OAuth2LoginConfigurer} for further customizations
-	 * @throws Exception
 	 */
-	public OAuth2LoginConfigurer<B> userInfoEndpoint(Customizer<UserInfoEndpointConfig> userInfoEndpointCustomizer)
-			throws Exception {
+	public OAuth2LoginConfigurer<B> userInfoEndpoint(Customizer<UserInfoEndpointConfig> userInfoEndpointCustomizer) {
 		userInfoEndpointCustomizer.customize(this.userInfoEndpointConfig);
 		return this;
 	}

config/src/main/java/org/springframework/security/config/annotation/web/configurers/oauth2/server/resource/OAuth2ResourceServerConfigurer.java

@@ -188,9 +188,8 @@ public JwtConfigurer jwt() {
 	 * @param jwtCustomizer the {@link Customizer} to provide more options for
 	 * the {@link JwtConfigurer}
 	 * @return the {@link OAuth2ResourceServerConfigurer} for further customizations
-	 * @throws Exception
 	 */
-	public OAuth2ResourceServerConfigurer<H> jwt(Customizer<JwtConfigurer> jwtCustomizer) throws Exception {
+	public OAuth2ResourceServerConfigurer<H> jwt(Customizer<JwtConfigurer> jwtCustomizer) {
 		if ( this.jwtConfigurer == null ) {
 			this.jwtConfigurer = new JwtConfigurer(this.context);
 		}
@@ -212,10 +211,8 @@ public OpaqueTokenConfigurer opaqueToken() {
 	 * @param opaqueTokenCustomizer the {@link Customizer} to provide more options for
 	 * the {@link OpaqueTokenConfigurer}
 	 * @return the {@link OAuth2ResourceServerConfigurer} for further customizations
-	 * @throws Exception
 	 */
-	public OAuth2ResourceServerConfigurer<H> opaqueToken(Customizer<OpaqueTokenConfigurer> opaqueTokenCustomizer)
-			throws Exception {
+	public OAuth2ResourceServerConfigurer<H> opaqueToken(Customizer<OpaqueTokenConfigurer> opaqueTokenCustomizer) {
 		if (this.opaqueTokenConfigurer == null) {
 			this.opaqueTokenConfigurer = new OpaqueTokenConfigurer(this.context);
 		}

config/src/main/java/org/springframework/security/config/annotation/web/configurers/openid/OpenIDLoginConfigurer.java

@@ -157,10 +157,8 @@ public AttributeExchangeConfigurer attributeExchange(String identifierPattern) {
 	 * @param attributeExchangeCustomizer the {@link Customizer} to provide more options for
 	 * the {@link AttributeExchangeConfigurer}
 	 * @return a {@link OpenIDLoginConfigurer} for further customizations
-	 * @throws Exception
 	 */
-	public OpenIDLoginConfigurer<H> attributeExchange(Customizer<AttributeExchangeConfigurer> attributeExchangeCustomizer)
-			throws Exception {
+	public OpenIDLoginConfigurer<H> attributeExchange(Customizer<AttributeExchangeConfigurer> attributeExchangeCustomizer) {
 		AttributeExchangeConfigurer attributeExchangeConfigurer = new AttributeExchangeConfigurer(".*");
 		attributeExchangeCustomizer.customize(attributeExchangeConfigurer);
 		this.attributeExchangeConfigurers.add(attributeExchangeConfigurer);
@@ -458,9 +456,8 @@ public AttributeConfigurer attribute(String name) {
 		 * @param attributeCustomizer the {@link Customizer} to provide more options for
 		 * the {@link AttributeConfigurer}
 		 * @return a {@link AttributeExchangeConfigurer} for further customizations
-		 * @throws Exception
 		 */
-		public AttributeExchangeConfigurer attribute(Customizer<AttributeConfigurer> attributeCustomizer) throws Exception {
+		public AttributeExchangeConfigurer attribute(Customizer<AttributeConfigurer> attributeCustomizer) {
 			AttributeConfigurer attributeConfigurer = new AttributeConfigurer();
 			attributeCustomizer.customize(attributeConfigurer);
 			this.attributeConfigurers.add(attributeConfigurer);