Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Forge v6 blog post #278

Merged
merged 16 commits into from
Nov 3, 2022
Merged

chore: Forge v6 blog post #278

merged 16 commits into from
Nov 3, 2022

Conversation

georgexu99
Copy link
Contributor

initial PR to get things going ahead of forge v6 release.

Questions/ areas of note

  • I refer to forge v6 as: Electron Forge v6, Forge, Forge v6 let me know if this should be standardized
  • breaking changes needs to be fleshed out

@georgexu99 georgexu99 marked this pull request as ready for review October 13, 2022 00:12
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
@georgexu99 georgexu99 force-pushed the gxu-forge-v6-blogpost branch from 2eda178 to c61c2dc Compare October 13, 2022 23:56
@georgexu99 georgexu99 force-pushed the gxu-forge-v6-blogpost branch from c61c2dc to d708384 Compare October 13, 2022 23:59
@VerteDinde
Copy link
Member

We should probably add a "Migrating from v5 to v6" section, just to outline the major changes people will need to look out for.

@georgexu99
Copy link
Contributor Author

We should probably add a "Migrating from v5 to v6" section, just to outline the major changes people will need to look out for.

I removed this section as per Erick's first comment- given that 1/30 of our users are using v5, and that the migration guide basically says "run the script, resolve any remaining conflicts in the config" it may not be valuable in the blog

blog/forge-v6-release.md Outdated Show resolved Hide resolved
@georgexu99 georgexu99 requested review from erickzhao and a team October 24, 2022 17:08
@georgexu99 georgexu99 force-pushed the gxu-forge-v6-blogpost branch from f5b703e to 617855a Compare October 27, 2022 23:25
@georgexu99 georgexu99 force-pushed the gxu-forge-v6-blogpost branch from 617855a to fc894c6 Compare October 28, 2022 23:57
@VerteDinde VerteDinde self-requested a review October 31, 2022 15:12
@VerteDinde VerteDinde self-requested a review October 31, 2022 15:39
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
@georgexu99 georgexu99 force-pushed the gxu-forge-v6-blogpost branch from fc2b304 to 26f7668 Compare October 31, 2022 23:58
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
@georgexu99 georgexu99 force-pushed the gxu-forge-v6-blogpost branch from 26f7668 to 03c85fb Compare November 1, 2022 00:17
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentative ✅ - going to hold off approving until we're ready to merge (right after stable)

blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
@georgexu99 georgexu99 force-pushed the gxu-forge-v6-blogpost branch from 03c85fb to 8fce9e4 Compare November 1, 2022 17:26
@erickzhao erickzhao dismissed BlackHole1’s stale review November 1, 2022 17:35

Comment was resolved

blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
blog/forge-v6-release.md Outdated Show resolved Hide resolved
@georgexu99 georgexu99 force-pushed the gxu-forge-v6-blogpost branch from 7200c59 to 5a7bb5e Compare November 2, 2022 00:27
blog/forge-v6-release.md Outdated Show resolved Hide resolved
@georgexu99 georgexu99 force-pushed the gxu-forge-v6-blogpost branch from 1202f14 to 01665d1 Compare November 2, 2022 23:40
blog/forge-v6-release.md Outdated Show resolved Hide resolved
@erickzhao erickzhao force-pushed the gxu-forge-v6-blogpost branch from ff67c09 to bf48d2e Compare November 3, 2022 04:51
@erickzhao erickzhao force-pushed the gxu-forge-v6-blogpost branch from bf48d2e to 267553b Compare November 3, 2022 04:52
@VerteDinde VerteDinde merged commit 2746f4c into main Nov 3, 2022
@VerteDinde VerteDinde deleted the gxu-forge-v6-blogpost branch November 3, 2022 16:17
@georgexu99
Copy link
Contributor Author

WOO 🍾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants