Skip to content

Commit

Permalink
fix: prevent checking isDesktopCapturerEnabled, which crashes on elec…
Browse files Browse the repository at this point in the history
…tron@26 (#154)

* Avoid crash with electron 26

Not sure of the side effects of this

* Checking isDesktopCapturerEnabled is no longer necessary or possible. Fixes #153

Context electron/electron#38412

* Revert to checking isDesktopCapturerEnabled for pre-26 electron versions
  • Loading branch information
JuanIrache committed Jun 5, 2023
1 parent a6c1cc2 commit 9f543a1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/common/module-names.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const browserModuleNames = [

const features = getElectronBinding('features');

if (!features || features.isDesktopCapturerEnabled()) {
if (!features || !features.isDesktopCapturerEnabled || features.isDesktopCapturerEnabled()) {
browserModuleNames.push('desktopCapturer');
}

Expand Down

0 comments on commit 9f543a1

Please sign in to comment.