Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old icon remains in .NET binaries after SetIcon #27

Closed
RaptDept opened this issue Aug 2, 2016 · 1 comment
Closed

Old icon remains in .NET binaries after SetIcon #27

RaptDept opened this issue Aug 2, 2016 · 1 comment

Comments

@RaptDept
Copy link
Contributor

RaptDept commented Aug 2, 2016

If you view a .NET binary in ResourceHacker after calling --set-icon, you'll see that the old icons are still in the binary while the new ones sit in a separate icon bundle. If the old icon bundle has more icons than the new one, some of the old icons won't be overridden.
@RaptDept RaptDept mentioned this issue Aug 2, 2016
Merged
@kevinsawicki
Copy link
Contributor

Fixed by #26

chuckrector pushed a commit to chuckrector/rcedit that referenced this issue Jan 18, 2022
Fix an old icon cleanup bug similar to issue electron#27 that was int…
44778f5 
…roduced by pull electron#54.
chuckrector pushed a commit to chuckrector/rcedit that referenced this issue Jan 18, 2022
fix: Cleanup old icons. This updates the correct field rather than as…
dad2bf2 
…signing the new max to a local variable. This bug was introduced by pull electron#54 which landed after the fix for a similar bug that was described in issue electron#27.
chuckrector pushed a commit to chuckrector/rcedit that referenced this issue Jan 18, 2022
fix: Cleanup old icons. This updates the correct field rather than as…
877ef00 
…signing the new max to a local variable. This bug was introduced by pull electron#54 which landed after the fix to a similar bug that was described in issue electron#27.
chuckrector pushed a commit to chuckrector/rcedit that referenced this issue Jan 18, 2022
fix: Cleanup old icons correctly.
d9a8781 
This updates the correct field rather than assigning the new max to a local variable. This bug was introduced by pull electron#54 which landed after the fix to a similar bug that was described in issue electron#27.
chuckrector pushed a commit to chuckrector/rcedit that referenced this issue Jan 18, 2022
fix: cleanup old icons correctly.
855e986 
This updates the correct field rather than assigning the new max to a local variable. This bug was introduced by pull electron#54 which landed after the fix to a similar bug that was described in issue electron#27.
chuckrector added a commit to chuckrector/rcedit that referenced this issue Jan 18, 2022
@chuckrector
fix: cleanup old icons correctly.
7e22bad 
This updates the correct field rather than assigning the new max to a local variable. This bug was introduced by pull electron#54 which landed after the fix to a similar bug that was described in issue electron#27.
chuckrector added a commit to chuckrector/rcedit that referenced this issue Jan 18, 2022
@chuckrector
fix: cleanup old icons correctly.
808d8ff 
This updates the correct field rather than assigning the new max to a local variable. If you set an icon with 10 images and then later set an icon with one image, 9 images would linger in the executable. This bug was introduced by pull electron#54 which landed after the fix to a similar bug that was described in issue electron#27.
chuckrector added a commit to chuckrector/rcedit that referenced this issue Jan 18, 2022
@chuckrector
fix: cleanup old icons correctly.
4b42c3e 
This updates the correct field rather than assigning the new max to a local variable. Previously, if you had set an icon with 10 images and then later set a new icon with only one image, 9 old image would linger in the executable. This bug was introduced by pull electron#54 which landed after the fix to a similar bug that was described in issue electron#27.
chuckrector added a commit to chuckrector/rcedit that referenced this issue Jan 18, 2022
@chuckrector
fix: cleanup old icons correctly.
b674993 
This updates the correct field rather than assigning the new max to a local variable. Previously, if you had set an icon with ten images and then later set a new icon with only one image, nine old images would linger in the executable. If you revised the icon over time and reduced the number of images each time, you would end up with old icons from multiple different passes. This bug was introduced by pull electron#54 which landed after the fix to a similar bug that was described in issue electron#27.
chuckrector added a commit to chuckrector/rcedit that referenced this issue Jan 18, 2022
@chuckrector
fix: cleanup old icons correctly.
599b353 
This updates the correct field rather than assigning the new max to a local variable. Previously, if you had set an icon with ten images and then later set a new icon with only one image, nine old images would linger in the executable. If you revised your icon over time and reduced the number of images each time, old icons from multiple different passes would linger in the executable. This bug was introduced by pull electron#54 which landed after the fix to a similar bug that was described in issue electron#27.
chuckrector added a commit to chuckrector/rcedit that referenced this issue Jan 18, 2022
@chuckrector
fix: cleanup old icons correctly.
82897b1 
This updates the correct field rather than assigning the new max icon ID to a local variable. Previously, if you had set an icon with ten images and then later set a new icon with only one image, nine old images would linger in the executable. If you revised your icon over time and reduced the number of images each time, old icons from multiple different passes would linger in the executable. This bug was introduced by pull electron#54 which landed after the fix to a similar bug that was described in issue electron#27.
chuckrector added a commit to chuckrector/rcedit that referenced this issue Jan 18, 2022
@chuckrector
fix: cleanup old icons correctly.
ee3fc8d 
This updates the correct field rather than assigning the new max icon ID to a local variable. Previously, if you had set an icon with ten images and then later set a new icon with only one image, nine old images would linger in the executable. If you revised your icon over time and reduced the number of images each time, old icons from multiple different passes would linger in the executable.

This bug was introduced by pull electron#54 which landed after the fix to a similar bug that was described in issue electron#27.
chuckrector added a commit to chuckrector/rcedit that referenced this issue Jan 18, 2022
@chuckrector
fix: cleanup old icons correctly.
0fca48f 
This updates the correct field rather than assigning the new max icon ID to a local variable. Previously, if you had set an icon with ten images and then later set a new icon with only one image, nine old images would linger in the executable. If you revised your icon over time and reduced the number of images each time, old icons from multiple different passes would linger in the executable.

This bug was introduced by af37f5f which landed after the fix to a similar bug that was described in issue electron#27.
chuckrector added a commit to chuckrector/rcedit that referenced this issue Jan 18, 2022
@chuckrector
fix: cleanup old icons correctly.
072d463 
0123456789012345678901234567890123456789012345678901234567890123456789
This updates the correct field rather than assigning the new max icon ID
to a local variable. Previously, if you had set an icon with ten images
and then later set a new icon with only one image, nine old images would
linger in the executable. If you revised your icon over time and reduced
the number of images each time, old icons from multiple different passes
would linger in the executable.

This bug was introduced by af37f5f which landed after the fix to a
similar bug that was described in issue electron#27.
chuckrector added a commit to chuckrector/rcedit that referenced this issue Jan 18, 2022
@chuckrector
fix: cleanup old icons correctly.
693f915 
This updates the correct field rather than assigning the new max icon ID
to a local variable. Previously, if you had set an icon with ten images
and then later set a new icon with only one image, nine old images would
linger in the executable. If you revised your icon over time and reduced
the number of images each time, old icons from multiple different passes
would linger in the executable.

This bug was introduced by af37f5f which landed after the fix to a
similar bug that was described in issue electron#27.
@chuckrector chuckrector mentioned this issue Jan 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinsawicki @RaptDept