feat: integrate @electron/universal #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1346 +/- ##
===========================================
- Coverage 100.00% 95.98% -4.02%
===========================================
Files 14 15 +1
Lines 733 773 +40
===========================================
+ Hits 733 742 +9
- Misses 0 31 +31
Continue to review full report at Codecov.
|
3 tasks
erickzhao
approved these changes
Apr 13, 2022
| @@ -16,6 +16,9 @@ import { | |||
| TransporterOptions | |||
| } from 'electron-notarize/lib/types'; | |||
| import { SignOptions } from 'electron-osx-sign'; | |||
| import type { makeUniversalApp } from '@electron/universal'; | |||
|
|
|||
| type MakeUniversalOpts = Parameters<typeof makeUniversalApp>[0] | |||
There was a problem hiding this comment.
note: this leverages Parameters in TS to get the args for makeUniversalApp since @electron/universal doesn't expose them.
| * app with the target architecture of "universal". Unused otherwise, providing a value does not imply | ||
| * a universal app is built. | ||
| */ | ||
| osxUniversal?: OsxUniversalOptions; |
5 tasks
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in title, this integrates @electron/universal into packager by intercepting package requests for "universal" and then building arm64 / x64 separately behind the scenes and stitching them together.