fix: BN_bn2bin_padded returns 1 on success instead of size

fixup! fix: update with BORINGSSL api for node_crypto.cc
electron · Mar 18, 2019 · e56bc4f · e56bc4f
1 parent 6f2df27
commit e56bc4f
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -4221,7 +4221,7 @@ void DiffieHellman::GenerateKeys(const FunctionCallbackInfo<Value>& args) {
   auto* allocator = env->isolate()->GetArrayBufferAllocator();
   char* data = static_cast<char*>(allocator->AllocateUninitialized(size));
   CHECK_EQ(
-      size,
+      1,
       BN_bn2bin_padded(reinterpret_cast<unsigned char*>(data), size, pub_key));
   args.GetReturnValue().Set(Buffer::New(env, data, size).ToLocalChecked());
 }
@@ -4242,7 +4242,7 @@ void DiffieHellman::GetField(const FunctionCallbackInfo<Value>& args,
   CHECK_GE(size, 0);
   auto* allocator = env->isolate()->GetArrayBufferAllocator();
   char* data = static_cast<char*>(allocator->AllocateUninitialized(size));
-  CHECK_EQ(size,
+  CHECK_EQ(1,
            BN_bn2bin_padded(reinterpret_cast<unsigned char*>(data), size, num));
   args.GetReturnValue().Set(Buffer::New(env, data, size).ToLocalChecked());
 }
@@ -4588,7 +4588,7 @@ void ECDH::GetPrivateKey(const FunctionCallbackInfo<Value>& args) {
   unsigned char* out =
       static_cast<unsigned char*>(allocator->AllocateUninitialized(size));
 
-  if (size != BN_bn2bin_padded(out, size, b)) {
+  if (!BN_bn2bin_padded(out, size, b)) {
     allocator->Free(out, size);
     return env->ThrowError("Failed to convert ECDH private key to Buffer");
   }