add entries for Node 12 and Electron 5 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 24, 2019
shiftkey
changed the title
jacobq
reviewed
Apr 24, 2019
|
Would you mind also updating the test suite for t.equal(getAbi('5.0.0', 'electron'), '70')
t.equal(getAbi('4.1.4', 'electron'), '69')
t.equal(getAbi('4.0.4', 'electron'), '69')
t.equal(getAbi('4.0.3', 'electron'), '64')
t.equal(getAbi('3.1.8', 'electron'), '64')
t.equal(getAbi('2.0.18', 'electron'), '57') |
Co-Authored-By: Jacob <jacobq@users.noreply.github.com>
|
❤️ @lgeiger Any reason not to merge? Do we need to update the dates/logic regarding |
|
Hrm, this didn't trigger a new release. Possibly because the commit message wasn't in the proper format? |
|
🎉 This PR is included in version 2.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hm, I guess I was too impatient 🤷♂️ |
This was referenced Apr 25, 2019
|
@malept I manually kicked it with an empty release 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the details are correct here, based on the details in https://nodejs.org/en/download/releases/. and https://github.com/nodejs/node/blob/master/doc/abi_version_registry.json
Let me know if anything is unclear.