Use sccache to speed up builds #522
Conversation
|
It appears that our current S3 configuration isn't working due to this issue: Here is an example build where it missed 100% of a warmed cache: |
|
@jkleinsc There is a way around this, pinging you in Slack 👍 |
.circleci/config.yml
Outdated
| command: script/update --clean -t $TARGET_ARCH --use-bundled-sccache | ||
| - run: | ||
| name: Check sccache stats before build | ||
| command: tools/sccache/0.2.6/linux/sccache -s |
There was a problem hiding this comment.
Maybe we can add a wrapper script to run bundled sccache? Like script/sccache that would run bundled sccache for current platform?
These absolute paths with versions and platforms in them look difficult to maintain.
There was a problem hiding this comment.
@alexeykuzmin that's not a bad idea, though I added these calls just to see if sccache was actually doing anything and wasn't planning on leaving them in.
|
@alexeykuzmin good point. I’ll make the change. |
|
Git shows the linux version of sccache as simply renamed: Is it true? ) |
No, because if you look at the linux build result here, its using the Azure storage which wasn't available in 0.2.6: https://circleci.com/gh/electron/libchromiumcontent/6413 |
|
@jkleinsc Shall we merge it? ) |
| @@ -50,7 +56,7 @@ jobs: | |||
| command: script/bootstrap | |||
| - run: | |||
| name: Update | |||
| command: script/update --clean -t $TARGET_ARCH | |||
| command: script/update --clean -t $TARGET_ARCH --use-bundled-sccache | |||
There was a problem hiding this comment.
Somehow missed it.
I thought we agreed on not using cache for Release builds.
There was a problem hiding this comment.
@alexeykuzmin why would we not use cache for Release builds???
There was a problem hiding this comment.
I mean it doesn't really gain us much if we only use this for shared builds. We still end up having to wait for the static builds. Given that we are using a cache that only the CI has write access to, I'm not sure why we wouldn't use it for Release builds.
There was a problem hiding this comment.
@jkleinsc For maximum safety, release builds should be generated in a 100% deterministic and isolated way. Generating them without cache is what everyone was 👍 on from memory
There was a problem hiding this comment.
Alright then, I changed it to just run for shared builds.
There was a problem hiding this comment.
@jkleinsc
I would personally vote for using cache everywhere.
But some people are concerned about potential security issues more than I am )
Anyway, I hope that some day we will build Release builds only when we are actually releasing something.
jkleinsc
changed the title
New binaries with Azure support Only use sccache for shared(debug) builds
This PR updates our CI to use sccache in order to speed up builds.
cc #516