Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin-vite): merge Vite build.lib config #3721

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix(plugin-vite): merge Vite build.lib config #3721

merged 1 commit into from
Nov 20, 2024

Conversation

caoxiemeihao
Copy link
Member

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
Closes #3715

@caoxiemeihao caoxiemeihao requested a review from a team as a code owner September 29, 2024 04:50
@caoxiemeihao caoxiemeihao force-pushed the fix/plugin-vite-merge branch 2 times, most recently from edd59b6 to e8e226d Compare September 29, 2024 04:56
@Nakus0426
Copy link

When will this pr be merged and released in the next version?

@BlackHole1 BlackHole1 force-pushed the fix/plugin-vite-merge branch from e8e226d to 10624d1 Compare November 8, 2024 02:06
@BlackHole1
Copy link
Member

PTAL @electron/forgers

@kms0219kms
Copy link

Why this PR is not merging? It works perfectly...

@VerteDinde VerteDinde added this pull request to the merge queue Nov 20, 2024
Merged via the queue into electron:main with commit c9a6247 Nov 20, 2024
12 checks passed
@sebbean
Copy link

sebbean commented Nov 24, 2024

this lets us bundle to esm not cjs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackHole1 BlackHole1 BlackHole1 approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@electron-forge/plugin-vite can no longer build main module as ESM (breaking config change)
6 participants
@caoxiemeihao @Nakus0426 @BlackHole1 @kms0219kms @sebbean @VerteDinde