Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-vite): avoid TS5055 #3711

Merged
merged 1 commit into from
Sep 21, 2024
Merged

fix(plugin-vite): avoid TS5055 #3711

merged 1 commit into from
Sep 21, 2024

Conversation

erickzhao
Copy link
Member

When publishing the Vite plugin with @electron/forgers, we ran into a weird issue with yarn build whenever the /dist/ file already existed:

yarn run v1.22.22
$ tsc -b packages
error TS5055: Cannot write file '/Users/erick.zhao/Developer/electron/forge/packages/plugin/vite/dist/Config.d.ts' because it would overwrite input file.

error TS5055: Cannot write file '/Users/erick.zhao/Developer/electron/forge/packages/plugin/vite/dist/VitePlugin.d.ts' because it would overwrite input file.

I took a quick peek at the problem and it seems like removing the reference to typeof import('@electron-forge/plugin-vite') helped fix the problem in build.

@erickzhao erickzhao requested a review from a team as a code owner September 21, 2024 05:21
Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@erickzhao erickzhao added this pull request to the merge queue Sep 21, 2024
Merged via the queue into main with commit 420458b Sep 21, 2024
13 checks passed
@erickzhao erickzhao deleted the vite/TS5055 branch September 21, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants