-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Fuses plugin #3132
feat: add Fuses plugin #3132
Conversation
f94c2aa
to
caeda9b
Compare
4a337e8
to
e39b49c
Compare
I had an issue where the test worked fine when running forge/packages/template/typescript-webpack/test/TypeScriptWebpackTemplate_spec_slow.ts Line 53 in af13a32
Without this line, rechoir fails to load
Also, when running the |
platform, | ||
}); | ||
|
||
await flipFuses(pathToElectronExecutable, this.fusesConfig); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue(blocking): we should specify the resetAdHocDarwinSignature
flag if the osxSign
option is not configured on arm64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it apply to the mas
target as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, what about arch=universal
?
"package": "electron-forge package" | ||
}, | ||
"dependencies": { | ||
"@electron-forge/plugin-fuses": "file:./../../../../fuses", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if there's a better way to test unreleased plugins
}, | ||
"dependencies": { | ||
"@electron-forge/plugin-fuses": "file:./../../../../fuses", | ||
"@electron-forge/shared-types": "6.0.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint throws a node/no-unpublished-import
at me when importing some packages if they're under devDependencies
, so I figured moving them to dependencies
would be better than adding a bunch of es-ignore
comments since it's a mock app anyway
platform, | ||
}); | ||
|
||
await flipFuses(pathToElectronExecutable, this.fusesConfig); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it apply to the mas
target as well?
platform, | ||
}); | ||
|
||
await flipFuses(pathToElectronExecutable, this.fusesConfig); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, what about arch=universal
?
f165145
to
3e3d322
Compare
3e3d322
to
929432e
Compare
Summarize your changes:
Plugin for Fuses.
Closes #3076.