refactor: use listr2 for the package, make and publish commands #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
MarshallOfSound
force-pushed
the
listr-package
branch
from
9beb849 to
c14bbe2
Compare
MarshallOfSound
changed the title
MarshallOfSound
changed the title
MarshallOfSound
changed the title
VerteDinde
reviewed
Nov 3, 2022
Comment on lines
+38
to
+39
| // This logic allows developers working on forge itself to easily init | ||
| // a local template and have it use their local plugins / core / cli packages |
There was a problem hiding this comment.
This is awesome! Any specific command devs can use to do this - is it LINK_FORGE_DEPENDENCIES_ON_INIT=true or running link:prepare? Just wondering if this is something we can document for future use.
There was a problem hiding this comment.
You run link:prepare and then when you call electron-forge-init.js manually you have this env var set so it links correctly
VerteDinde
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a chonky PR but I did always say
packagewas gonna be the nightmarish one.The reason this is so funky is we run
packagefromelectron-packagerand want to show internal progress without packager being away of listr. This results in thesignalpattern I implemented (which honestly isn't that bad now it's been cleaned up a bit).The point is this output looks so dope now:
Screen.Recording.2022-11-02.at.1.14.28.AM.mov
This PR also adds support for some important things like make it possible:
The last remaining usage of
async-orais theimportcommand which should probably be a separate PR, this one is already too chonky.