Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-electronegativity): add electronVersion option #2819

Closed
wants to merge 1 commit into from

Conversation

guizmaii
Copy link

@guizmaii guizmaii commented Apr 22, 2022

resolve #2818

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #2819 (29e515b) into master (9fcd08f) will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2819      +/-   ##
==========================================
+ Coverage   75.62%   75.91%   +0.29%     
==========================================
  Files          77       77              
  Lines        2359     2338      -21     
  Branches      438      436       -2     
==========================================
- Hits         1784     1775       -9     
+ Misses        462      445      -17     
- Partials      113      118       +5     
Impacted Files Coverage Δ
packages/api/core/src/util/publish-state.ts 87.17% <0.00%> (-5.13%) ⬇️
packages/api/core/src/util/electron-executable.ts 96.00% <0.00%> (-4.00%) ⬇️
packages/api/core/src/util/upgrade-forge-config.ts 96.49% <0.00%> (-3.51%) ⬇️
packages/api/core/src/util/rebuild.ts 94.44% <0.00%> (-0.30%) ⬇️
packages/api/core/src/api/start.ts 78.31% <0.00%> (+0.66%) ⬆️
packages/api/core/src/api/make.ts 82.47% <0.00%> (+0.84%) ⬆️
packages/api/core/src/api/install.ts 89.33% <0.00%> (+1.17%) ⬆️
packages/installer/darwin/src/InstallerDarwin.ts 36.84% <0.00%> (+1.84%) ⬆️
packages/plugin/base/src/Plugin.ts 60.00% <0.00%> (+2.85%) ⬆️
packages/installer/linux/src/InstallerLinux.ts 45.45% <0.00%> (+3.78%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fcd08f...29e515b. Read the comment docs.

@guizmaii guizmaii closed this Apr 22, 2022
@guizmaii guizmaii reopened this Apr 22, 2022
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't expose this option to the user, forge knows what electronVersion you have. We should just pass this straight into electronegativity ourselves.

getElectronVersion is the helper you want to call

@VerteDinde VerteDinde closed this Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugin-electronegativity error: "warn: Couldn't detect Electron version, assuming v0.1.0"
3 participants