Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swipe back/forward should respect system preferences #6686

Merged
merged 2 commits into from
Aug 3, 2016
Merged

Swipe back/forward should respect system preferences #6686

merged 2 commits into from
Aug 3, 2016

Conversation

darkdh
Copy link
Contributor

@darkdh darkdh commented Aug 2, 2016

@zcbenz
Copy link
Contributor

zcbenz commented Aug 2, 2016

Theses events are not always used for swiping back/forward, for example in N1 it is used for archiving emails (#4181). So I think a more flexible way is to expose an systemPreferences.isSwipeTrackingFromScrollEventsEnabled() API, and Brave browser can use it to decide the behavior.

@darkdh
Copy link
Contributor Author

darkdh commented Aug 3, 2016

Thanks for the advice, @zcbenz. I've put it in e0c0e3e

@zcbenz
Copy link
Contributor

zcbenz commented Aug 3, 2016

👍

@zcbenz zcbenz merged commit 322fb97 into electron:master Aug 3, 2016
@darkdh darkdh mentioned this pull request Aug 3, 2016
Merged
@darkdh darkdh deleted the swipe_prefs branch August 4, 2016 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darkdh @zcbenz