-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement net.fetch #36733
feat: implement net.fetch #36733
Conversation
Alrighty, I've been running this implementation against the Web Platform Tests (WPT) via a hacked-up version of undici's test harness, and it's doing pretty good so far:
the remaining "unexpected failures" are:
In addition, net.fetch doesn't support I think none of these are sufficiently bad problems to prevent shipping, so I'm taking this out of draft mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like changes from #37099 are mixed in, a rebase would be good.
Release Notes Persisted
|
Description of Change
This implements
net.fetch()
, by analogy tofetch()
on the Web andfetch()
in Node, but using Chromium's network stack.
Checklist
npm test
passesRelease Notes
Notes: Added
net.fetch()
.