-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add V8CacheOptions webpreference #23842
Conversation
This is awesome, and my 2 cents are that Electron by default should cache on the first startup as much as possible because an Electron app deserves to be cached right from the beginning, as opposed to any website I visit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just a small nit on capitalization.
Release Notes Persisted
|
I have automatically backported this PR to "10-x-y", please check out #23867 |
I have automatically backported this PR to "9-x-y", please check out #23868 |
I have automatically backported this PR to "8-x-y", please check out #23869 |
Couple of things to remember,
|
Electron 11 is set to be a quiet release, so we don't do any breaking changes in master at the moment. Will switch the default in near future. |
Description of Change
Refs microsoft/vscode#98682 (comment) for context
Checklist
npm test
passesRelease Notes
Notes: V8CacheOptions is a new webpreference option to enforce code caching policy