-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow providing properties (such as unpack
) in ordering
input file
#350
feat: allow providing properties (such as unpack
) in ordering
input file
#350
Conversation
unpack
) in ordering
input file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had only one small comment, but I'm overall okay with this. Seems honestly like a good approach. I'll wait for @VerteDinde to take a look but otherwise I'm game for shipping this through!
…make it more readable
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Part 1 for fixing electron/universal#117
This implementation achieves proposal
2b
Excerpt below:
In allowing more explicit control within the ordering file, advanced usage of electron/asar is provided (and kind of needed for electron/universal's current auto-unpack logic) to bypass limitations of the
minimatch
packageRight now, the "ordering" file is simply of format:
Right now,
electron/asar
only pulls the filename value before the:
asar/src/asar.ts
Lines 92 to 95 in 121efeb
This proposal is to leverage
<anything>
to beJSON.stringify
of Type:Notes:
--ordering
property, just extracted to a separate functionordering
file sets for any test that wants to leverage it.