Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix issues with conflictDependency that have two or more layers #8481

Merged
merged 9 commits into from
Sep 15, 2024

Conversation

beyondkmp
Copy link
Collaborator

@beyondkmp beyondkmp commented Sep 13, 2024

Currently, only the first-level conflicting dependencies are added back. Second-level and subsequent dependencies are not added, which can lead to errors due to inability to find the corresponding versions of dependencies.

[
	{
		"Name": "A1",
		"conflictDependency": [
			{
				"Name": "B",
				"conflictDependency": [
					{
						"Name": "c"
					}
				]
			}
		]
	}
]

Copy link

changeset-bot bot commented Sep 13, 2024

🦋 Changeset detected

Latest commit: 174649c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
app-builder-lib Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 174649c
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/66e54b029fae220008e4b28f
😎 Deploy Preview https://deploy-preview-8481--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@beyondkmp beyondkmp changed the title fix: Fix issues with conficDependencies that have two or more layers fix: Fix issues with conflictDependency that have two or more layers Sep 13, 2024
@mmaietta mmaietta merged commit 216eaf9 into electron-userland:master Sep 15, 2024
13 checks passed
xyloflake pushed a commit to xyloflake/electron-builder that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants