Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(win): implement Azure Trusted Signing #8458

Merged
merged 29 commits into from
Sep 13, 2024
Merged

feat(win): implement Azure Trusted Signing #8458

merged 29 commits into from
Sep 13, 2024

Conversation

mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Sep 9, 2024

Implements: #8276

Adds signtool.exe-related args to sub-config signtoolOptions so that a new sub-config azureOptions can be used for configuring Azure Trusted Signing. To maintain backward compatibility, the previous config has been marked deprecated and the values passed there will be fallback values for the new signtoolOptions.<field_name>

Copy link

changeset-bot bot commented Sep 9, 2024

🦋 Changeset detected

Latest commit: 4f52977

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Minor
dmg-builder Minor
electron-builder-squirrel-windows Minor
electron-builder Minor
electron-forge-maker-appimage Minor
electron-forge-maker-nsis-web Minor
electron-forge-maker-nsis Minor
electron-forge-maker-snap Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 4f52977
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/66e3d00405e2e4000845d971
😎 Deploy Preview https://deploy-preview-8458--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta
Copy link
Collaborator Author

mmaietta commented Sep 9, 2024

Okay, got this working up until the point it does Invoke-TrustedSigning as then the parallels VM prompts for Endpoint, which I don't have an account with which to test with. Requires NuGet package provider to be installed and TrustedSigning module, but both also required "-Scope", "CurrentUser" since the cmd prompt that is automatically executed within a parallels VM is not elevated to admin.

Logs below with DEBUG=electron-builder

  • signing         file=dist/win-unpacked/electron-quick-start-typescript.exe certificateFile=Foo Bar.pfx
  • signing with Azure Trusted Signing  path=/Users/dev/Development/electron-builder-test-2/dist/win-unpacked/electron-quick-start-typescript.exe
  • executing       file=prlctl args=list -i -s name
  • executing       file=prlctl args=exec {6db0fa46-4f04-432a-a546-f8584beac98f} --current-user powershell.exe -NoProfile -NonInteractive -Command Get-Command pwsh.exe
  • ensure that 'Share folders' is set to 'All Disks', see https://goo.gl/E6XphP
  • unable to find pwsh.exe, falling back to powershell.exe
  • executing       file=prlctl args=exec {6db0fa46-4f04-432a-a546-f8584beac98f} --current-user powershell.exe Install-PackageProvider -Name NuGet -MinimumVersion 2.8.5.201 -Force -Scope CurrentUser
  • executed        file=prlctl stdout=
Name                           Version          Source           Summary                                               
----                           -------          ------           -------                                               
nuget                          2.8.5.208        https://onege... NuGet provider for the OneGet meta-package manager    
                      
  • executing       file=prlctl args=exec {6db0fa46-4f04-432a-a546-f8584beac98f} --current-user powershell.exe Install-Module -Name TrustedSigning -RequiredVersion 0.4.1 -Force -Repository PSGallery -Scope CurrentUser
  • executed        file=prlctl
  • executing       file=prlctl args=exec {6db0fa46-4f04-432a-a546-f8584beac98f} --current-user powershell.exe Invoke-TrustedSigning -Files /Users/dev/Development/electron-builder-test-2/dist/win-unpacked/electron-quick-start-typescript.exe

The current solution is a bit disorganized, likely will need a large refactor since things like cscInfo are no longer required. Then the tedious task of updating the docs will need to happen as well.

@mmaietta mmaietta marked this pull request as ready for review September 13, 2024 14:28
@mmaietta mmaietta merged commit d50d563 into master Sep 13, 2024
15 checks passed
@mmaietta mmaietta deleted the azure-signing branch September 13, 2024 18:34
@github-actions github-actions bot mentioned this pull request Sep 13, 2024
xyloflake pushed a commit to xyloflake/electron-builder that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants