Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow usage of module type config files #8455

Merged
merged 10 commits into from
Sep 8, 2024

Conversation

mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Sep 7, 2024

Fixes: #8389 #8435 #8451

Copy link

changeset-bot bot commented Sep 7, 2024

🦋 Changeset detected

Latest commit: 8bd4de1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
electron-builder Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Sep 7, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 8bd4de1
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/66ddcde831786900080b64d3
😎 Deploy Preview https://deploy-preview-8455--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta mmaietta force-pushed the read-config-file-implementation branch from d80fb68 to 8bd4de1 Compare September 8, 2024 16:16
@mmaietta mmaietta merged commit 5c8373d into master Sep 8, 2024
15 checks passed
@mmaietta mmaietta deleted the read-config-file-implementation branch September 8, 2024 16:29
@Matse2005
Copy link

When will a new version be released with this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESM Config filetype causes import issues in external dep (pkg read-config-file)
2 participants