-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: verify LiteralPath of update file during windows signature verification #8295
Conversation
🦋 Changeset detectedLatest commit: 106f800 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Are there any plans for a non-alpha release or backport? This is now showing up as https://nvd.nist.gov/vuln/detail/CVE-2024-39698 |
Yep, I'll be converting to non-alpha release when I return from vacation on Monday. Unfortunately, I cannot backport with the current CI/CD setup using |
I see that 6.3.1 is on npm but under the |
It needs broader adoption before I can post to To leverage the fix in electron-updater 6.3.1, it does not require a specific version of electron or electron-builder. |
To prevent env var expansion during the signature verification step when executed via cmd.exe -> powershell, we need to verify the LiteralPath of the scanned asset and compare the string against the original intended update filename