Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow api key and keychain notarize #7861

Merged
merged 5 commits into from
Nov 13, 2023

Conversation

mifi
Copy link
Contributor

@mifi mifi commented Nov 1, 2023

Copy link

changeset-bot bot commented Nov 1, 2023

🦋 Changeset detected

Latest commit: dccd0c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Minor
dmg-builder Minor
electron-builder-squirrel-windows Minor
electron-builder Minor
electron-forge-maker-appimage Minor
electron-forge-maker-nsis-web Minor
electron-forge-maker-nsis Minor
electron-forge-maker-snap Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit dccd0c9
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/65518d281a64e20008a906f9
😎 Deploy Preview https://deploy-preview-7861--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mifi mifi changed the title allow api key and keychain notarize feat: allow api key and keychain notarize Nov 1, 2023
@mmaietta
Copy link
Collaborator

mmaietta commented Nov 4, 2023

tsc build step is failing with these errors:

Error: packages/app-builder-lib/src/macPackager.ts(484,36): error TS7006: Parameter 'appPath' implicitly has an 'any' type.
Error: packages/app-builder-lib/src/macPackager.ts(504,54): error TS2322: Type 'string | undefined' is not assignable to type 'string'.
  Type 'undefined' is not assignable to type 'string'.
Error: packages/app-builder-lib/src/macPackager.ts(504,67): error TS2322: Type 'string | undefined' is not assignable to type 'string'.
  Type 'undefined' is not assignable to type 'string'.
Error: packages/app-builder-lib/src/macPackager.ts(504,82): error TS2322: Type 'string | undefined' is not assignable to type 'string'.
  Type 'undefined' is not assignable to type 'string'.

Can you please add explicit types to the consts?

@mifi
Copy link
Contributor Author

mifi commented Nov 6, 2023

fixed some types. however i'm really struggling to fix the types for generateNotarizeOptions. when notarize: true i'm struggling to distinguish between legacy and non legacy options. and if I don't distinguish, it complains that notarytool option is missing, which makes sense because @electron/notarize types requires tool to be 'notarytool', which contradicts with their readme which says:

tool String - The notarization tool to use, default is notarytool

not sure if i'm misunderstanding something

@mmaietta mmaietta merged commit 906ffb1 into electron-userland:master Nov 13, 2023
12 checks passed
@github-actions github-actions bot mentioned this pull request Nov 13, 2023
mifi added a commit to mifi/electron-builder that referenced this pull request Nov 17, 2023
@mifi mifi mentioned this pull request Nov 17, 2023
mifi added a commit to mifi/electron-builder that referenced this pull request Nov 17, 2023
@bcomnes
Copy link
Contributor

bcomnes commented Dec 20, 2023

This is a great improvement, however at the moment, it isn't functional. I opened a small fix to make it work: #7951

tldr The notarization tool never runs when the API key is set and notarize is set to true, and there are no other workarounds that work without the fix. Hope we can land it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants