-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added support for overriding ‘preAutoEntitlements’ for electron/osx-sign #7642
Conversation
🦋 Changeset detectedLatest commit: 2263e6e The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@taozhou-glean I'm checking this again as I'm not sure about the purpose of |
Honestly I did not dig too deep on what auto entitlement does for mas, but it default to true from osx-sign (which is existing behavior as well), and I do know one attribute it added and required for mas is the |
I'm trying to follow along, but am confused. Is the current thought that |
this is exactly what happened to me before and what triggered me to send out this change. My assumption and also after comparing the final entitlements between two builds are, the autoentitlement adds the team id to every file but essentially it should just add it to the app file only. So to me it seems something with the osx-sign package, but did not have time to dig deeper, and also we want to have more granular control over entitlement, so disabling auto entitlement just fits us better. But feel free to dig deeper and propose some fix to the osx-sign ;) |
We recently upgraded from v22 to v24, and start getting
Not available for testing
in testflight, after comparing the entitlements, it looks like the issue is due to auto entitlements from osx-sign, after disabling it locally the issue is resolved.Also this should address #7579
default should be true as osx-sign is checking for false with
===
: https://github.com/electron/osx-sign/blob/cd9e8f1146610fb0f1bb0d88a5219b208594e5b1/src/sign.ts#L211