Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update @electron/rebuild version and update imports #7541

Merged
merged 3 commits into from
Apr 13, 2023
Merged

fix: update @electron/rebuild version and update imports #7541

merged 3 commits into from
Apr 13, 2023

Conversation

yannickm95
Copy link
Contributor

@yannickm95 yannickm95 commented Apr 13, 2023

closes #7540.

Update @electron/rebuild to v3.2.11 and update the imports.

@changeset-bot
Copy link

changeset-bot bot commented Apr 13, 2023

🦋 Changeset detected

Latest commit: 7310b18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 7310b18
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6437c8f35f090e0008a6ff6d
😎 Deploy Preview https://deploy-preview-7541--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yannickm95 yannickm95 changed the title fix: update @electron/builder version and update imports fix: update @electron/rebuild version and update imports Apr 13, 2023
@mmaietta mmaietta merged commit a4888ac into electron-userland:master Apr 13, 2023
@github-actions github-actions bot mentioned this pull request Apr 13, 2023
@davej
Copy link
Contributor

davej commented Apr 19, 2023

@mmaietta and @yannickm95 I'm seeing the following error on 24.2.1 on Mac.

 Error: Cannot find module '@electron/rebuild/lib/src/search-module'
    Require stack:
    - /Users/runner/work/1/s/desktopify/node_modules/dmg-builder/node_modules/app-builder-lib/out/electron/electronVersion.js
    - /Users/runner/work/1/s/desktopify/node_modules/dmg-builder/node_modules/app-builder-lib/out/electron/ElectronFramework.js
    - /Users/runner/work/1/s/desktopify/node_modules/dmg-builder/node_modules/app-builder-lib/out/packager.js
    - /Users/runner/work/1/s/desktopify/node_modules/dmg-builder/node_modules/app-builder-lib/out/index.js
    - /Users/runner/work/1/s/desktopify/node_modules/dmg-builder/out/dmg.js
    - /Users/runner/work/1/s/desktopify/node_modules/dmg-builder/out/dmgUtil.js
    - /Users/runner/work/1/s/desktopify/node_modules/app-builder-lib/out/macPackager.js
    - /Users/runner/work/1/s/desktopify/node_modules/app-builder-lib/out/packager.js
    - /Users/runner/work/1/s/desktopify/node_modules/app-builder-lib/out/index.js

@yannickm95
Copy link
Contributor Author

Could you check your lock file? so you are certain you are on version 24.2.1 of app-builder-lib and the version of @electron/rebuild is 3.2.11 or higher. What version manager do you use? I only tested it with yarn because that's what I used, but '@electron/rebuild/lib/src/search-module' is no longer referenced in 24.2.1 so would find it very strange I changed it to '@electron/rebuild/lib/search-module here https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/src/electron/electronVersion.ts#L1

@davej
Copy link
Contributor

davej commented Apr 19, 2023

@yannickm95, looking at the error again now and I see that it might be caused because I'm using an older version of dmg-builder. Just upgraded dmg-builder and will report back if that fixes it.

@davej
Copy link
Contributor

davej commented Apr 19, 2023

@yannickm95 That fixed it. My bad! Thanks for your help. 🙏

This was referenced Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

electron-builder install-app-deps no longer works on fresh install
3 participants