Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: two-package.json electron version query #7511

Merged
merged 7 commits into from
Mar 30, 2023

Conversation

mmaietta
Copy link
Collaborator

Fixes: #7494

@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2023

🦋 Changeset detected

Latest commit: 0bf7043

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
electron-builder Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Mar 30, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 0bf7043
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6424e3bc1da2d100083f56e0
😎 Deploy Preview https://deploy-preview-7511--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mmaietta mmaietta merged commit 16283cc into master Mar 30, 2023
@mmaietta mmaietta deleted the fix/two-package-json-native-modules branch March 30, 2023 01:55
@github-actions github-actions bot mentioned this pull request Mar 30, 2023
@davej
Copy link
Contributor

davej commented Apr 3, 2023

@mmaietta I believe this PR has broken the v24.1.2 release. I'm getting the following error:

    Error: Cannot compute electron version from installed node modules - none of the possible electron modules are installed.
    See https://github.com/electron-userland/electron-builder/issues/3984#issuecomment-504968246

Error is resolved by downgrading back to v24.0.0

@mmaietta
Copy link
Collaborator Author

mmaietta commented Apr 3, 2023

Hi @davej, this one explicitly fixed a related "cannot compute electron version" for 2 package.json projects (#7494)

Can you post logs with DEBUG=electron-builder env var or provide a sample gist/repo or public repo that I can fork?

@davej
Copy link
Contributor

davej commented Apr 3, 2023

Hi @davej, this one explicitly fixed a related "cannot compute electron version" for 2 package.json projects (#7494)

Can you post logs with DEBUG=electron-builder env var or provide a sample gist/repo or public repo that I can fork?

Thanks @mmaietta, yeah, it's curious that this caused the same issue but in the exact opposite direction for me. I don't have an easy repro but I'll try and put something together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builds failing after upgrading to electron-builder 24.x
2 participants