fix: Update MacOS signOptions on macPackager #7317 #7351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a10003d The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
filfreire
changed the title
filfreire
changed the title
filfreire
changed the title
Let's just remove the legacy options as otherwise I bet someone (incl. myself) may forget why we have both keys present. If something breaks, we should know fairly quickly 😅 |
|
@mmaietta I removed the legacy options following your feedback. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @mmaietta
Trying (almost) the same fix as suggested by @mayfield in this comment #7317 (comment). I'm leaving the old legacy options in for now, I reckon they will be ignored when using the new https://github.com/electron/osx-sign ?
Not sure if in this case we should leave the legacy stuff in. There's a migration guide that can be checked for reference: https://github.com/electron/osx-sign/blob/a9cfce77512358420a850abfc102f784e02f8138/MIGRATION.md