Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nsis): specify full path to system's find #6771

Merged

Conversation

indutny-signal
Copy link
Contributor

GIT-SCM installation can override window's native find command line
tool with the one from unix tools. This in turn changes the exit code of
the whole find process command and makes us detect the app as running
even though it is not.

Credit and original fix by @theAddict

See signalapp/Signal-Desktop#5856

GIT-SCM installation can override window's native `find` command line
tool with the one from unix tools. This in turn changes the exit code of
the whole find process command and makes us detect the app as running
even though it is not.

Credit and original fix by @theAddict
@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2022

🦋 Changeset detected

Latest commit: 2c42f9c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Apr 7, 2022

Deploy Preview for car-park-attendant-cleat-11576 failed.

Name Link
🔨 Latest commit 2c42f9c
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/624f3a17c1f9a60009b01e08

@indutny-signal
Copy link
Contributor Author

cc @I-Otsuki

@mmaietta mmaietta merged commit e6c2a62 into electron-userland:master Apr 7, 2022
@mmaietta
Copy link
Collaborator

mmaietta commented Apr 7, 2022

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants