Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: latest node-gyp with old Electron versions #6402

Merged
merged 2 commits into from
Nov 9, 2021
Merged

fix: latest node-gyp with old Electron versions #6402

merged 2 commits into from
Nov 9, 2021

Conversation

zcbenz
Copy link

@zcbenz zcbenz commented Nov 8, 2021

Since node-gyp >= 8.4.0, building modules for old versions of Electron requires passing --force-process-config due to them lacking a valid config.gypi in their headers.

See also nodejs/node-gyp#2497.

@changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2021

🦋 Changeset detected

Latest commit: 7458c08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mmaietta
Copy link
Collaborator

mmaietta commented Nov 8, 2021

Thank you @zcbenz !

@mmaietta mmaietta merged commit f41d5f3 into electron-userland:master Nov 9, 2021
@github-actions github-actions bot mentioned this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants