Skip to content

Commit

Permalink
fix: treat cscLink empty string same as absent (#8185)
Browse files Browse the repository at this point in the history
  • Loading branch information
mifi authored Apr 29, 2024
1 parent 3ae3589 commit 5e41c5e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/tame-balloons-walk.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"app-builder-lib": patch
---

fix: Treat cscLink empty string same as null
2 changes: 1 addition & 1 deletion packages/app-builder-lib/src/winPackager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export class WinPackager extends PlatformPackager<WindowsConfiguration> {
}

const cscLink = this.getCscLink("WIN_CSC_LINK")
if (cscLink == null) {
if (cscLink == null || cscLink === '') {

Check warning on line 66 in packages/app-builder-lib/src/winPackager.ts

View workflow job for this annotation

GitHub Actions / test-linux (ArtifactPublisherTest,BuildTest,ExtraBuildTest,RepoSlugTest,binDownloadTest,configura...

Replace `''` with `""`

Check warning on line 66 in packages/app-builder-lib/src/winPackager.ts

View workflow job for this annotation

GitHub Actions / test-linux (snapTest,debTest,fpmTest,protonTest)

Replace `''` with `""`
return Promise.resolve(null)
}

Expand Down

0 comments on commit 5e41c5e

Please sign in to comment.