fix: expand macro for ${version}/.icon-ico/ dir on Window's install…

…ers (#7763)
electron-userland · Sep 25, 2023 · 0cb1913 · 0cb1913
1 parent 84906bc
commit 0cb1913
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/yellow-games-beg.md b/.changeset/yellow-games-beg.md
@@ -0,0 +1,5 @@
+---
+"app-builder-lib": patch
+---
+
+fix: expand macro for ${version}/.icon-ico/ dir on Window's installers
diff --git a/packages/app-builder-lib/src/platformPackager.ts b/packages/app-builder-lib/src/platformPackager.ts
@@ -679,6 +679,7 @@ export abstract class PlatformPackager<DC extends PlatformSpecificBuildOptions>
 
   // convert if need, validate size (it is a reason why tool is called even if file has target extension (already specified as foo.icns for example))
   async resolveIcon(sources: Array<string>, fallbackSources: Array<string>, outputFormat: IconFormat): Promise<Array<IconInfo>> {
+    const output = this.expandMacro(this.config.directories!.output!);
     const args = [
       "icon",
       "--format",
@@ -688,7 +689,7 @@ export abstract class PlatformPackager<DC extends PlatformSpecificBuildOptions>
       "--root",
       this.projectDir,
       "--out",
-      path.resolve(this.projectDir, this.config.directories!.output!, `.icon-${outputFormat}`),
+      path.resolve(this.projectDir, output, `.icon-${outputFormat}`),
     ]
     for (const source of sources) {
       args.push("--input", source)