Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simple-git and add support for GIT_TOKEN #1910

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

rthic23
Copy link
Contributor

@rthic23 rthic23 commented Jul 26, 2024

  • Electrode Native Platform uses simple-git for git cli operations.
  • Right now ERN only has SSH to authenticate in CI. Updated simple-git to latest and add ability to support github_token to authenticate the cli commands.
  • Updated simple-git/promise since its going to be deprecated soon.
  • ern-core -> yarn build since typescript lib doesn't support DOM. Simple-git uses DOM object AbortSignal.

@rthic23 rthic23 requested review from friederbluemle and leekuo July 26, 2024 17:36
@rthic23 rthic23 force-pushed the update-simple-git branch 4 times, most recently from 24891b4 to 00947f1 Compare July 26, 2024 18:10
@rthic23 rthic23 force-pushed the update-simple-git branch from 00947f1 to ffd683e Compare July 26, 2024 22:42
@rthic23 rthic23 merged commit 0bdbbcc into electrode-io:master Jul 26, 2024
10 checks passed
@rthic23 rthic23 deleted the update-simple-git branch July 26, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants