Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/feat(parsers, BD, BD_NP): fix to handle HTML changes and add BD_NP exchange #7746

Merged
merged 2 commits into from
Jan 23, 2025
Merged

fix/feat(parsers, BD, BD_NP): fix to handle HTML changes and add BD_NP exchange #7746

merged 2 commits into from
Jan 23, 2025

Conversation

consideRatio
Copy link
Contributor

@consideRatio consideRatio commented Jan 15, 2025 •
edited
Loading

Issue

Description

  • Fixes an error raised by the parser seeing a new data column (Nepal import!)
  • Fixes a bug where datetime comparison fails when passing a datetime with a timezone, like done running poetry run test_parser "BD->NP" --target_datetime="2024-11-14 00:00 +06:00" for example
  • Adds historical test for the BD parser.
  • Adds the exchange config and data for BD_NP, where NP is expected to export 40MW regularly between June 15 and November 15. This is based on finding the new "Nepal" column and reading finding an article.

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@consideRatio
fix/feat(parsers, BD, BD_NP): fix to handle HTML changes and add BD_N…
d96d984 
…P exchange

- Fixes an error raised by new data column for Nepal
- Adds the exchange config and data for BD_NP, where NP is expected to
  export 40MW regularly between June 15 and November 15. This is based
  on finding the new "Nepal" column and reading finding [an article](https://kathmandupost.com/money/2024/11/16/nepal-begins-historic-power-export-to-bangladesh-via-india).
@github-actions github-actions bot added parser python Pull requests that update Python code tests zone config Pull request or issue for zone configurations exchange config Pull request or issue for exchange configurations labels Jan 15, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 15, 2025
View reviewed changes
parsers/test/mocks/ERP_PGCB/historical.html Dismissed Show dismissed Hide dismissed
parsers/test/mocks/ERP_PGCB/historical.html Dismissed Show dismissed Hide dismissed
parsers/test/mocks/ERP_PGCB/historical.html Dismissed Show dismissed Hide dismissed
@consideRatio consideRatio mentioned this pull request Jan 15, 2025
Open
VIKTORVAV99
VIKTORVAV99 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@VIKTORVAV99 VIKTORVAV99 enabled auto-merge (squash) January 23, 2025 08:52
@VIKTORVAV99 VIKTORVAV99 merged commit 3fae2c2 into electricitymaps:master Jan 23, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VIKTORVAV99 VIKTORVAV99 VIKTORVAV99 approved these changes

Assignees
No one assigned
Labels
exchange config Pull request or issue for exchange configurations parser python Pull requests that update Python code tests zone config Pull request or issue for zone configurations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@consideRatio @VIKTORVAV99